Changeset 249216 in webkit

Timestamp:

Aug 28, 2019 12:57:00 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

XLinkNames namespace is required before the 'href' attribute of SVG animate elements
​https://bugs.webkit.org/show_bug.cgi?id=201227

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-08-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

To get the animation target element, get the value of the "href" attribute
or the "xlink:href" attribute.

Tests: svg/custom/href-svg-namespace-animate-target.svg

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

LayoutTests:

• svg/custom/href-svg-namespace-animate-target-expected.svg: Added.
• svg/custom/href-svg-namespace-animate-target.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/href-svg-namespace-animate-target-expected.svg (added)
• LayoutTests/svg/custom/href-svg-namespace-animate-target.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        XLinkNames namespace is required before the 'href' attribute of SVG animate elements
+        https://bugs.webkit.org/show_bug.cgi?id=201227
+
+        Reviewed by Ryosuke Niwa.
+
+        * svg/custom/href-svg-namespace-animate-target-expected.svg: Added.
+        * svg/custom/href-svg-namespace-animate-target.svg: Added.
+
 2019-08-28  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        XLinkNames namespace is required before the 'href' attribute of SVG animate elements
+        https://bugs.webkit.org/show_bug.cgi?id=201227
+
+        Reviewed by Ryosuke Niwa.
+
+        To get the animation target element, get the value of the "href" attribute
+        or the "xlink:href" attribute.
+
+        Tests: svg/custom/href-svg-namespace-animate-target.svg
+
+        * svg/animation/SVGSMILElement.cpp:
+        (WebCore::SVGSMILElement::buildPendingResource):
+
 2019-08-28  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp

@@ -182 +182 @@
     String id;
     RefPtr<Element> target;
-    auto& href = getAttribute(XLinkNames::hrefAttr);
+    auto& href = getAttribute(SVGNames::hrefAttr, XLinkNames::hrefAttr);
     if (href.isEmpty())
         target = parentElement();