Changeset 249318 in webkit

Timestamp:

Aug 30, 2019 1:29:41 AM (5 years ago)

Author:

Philippe Normand

Message:

[WPE][Qt] loadingChanged signal parameter is unusable
​https://bugs.webkit.org/show_bug.cgi?id=201301

Reviewed by Carlos Garcia Campos.

Source/WebKit:

• UIProcess/API/wpe/qt/WPEQtView.h: Explicitely name signal

parameter. It is a runtime requirement for QML.

Tools:

• MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
• Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for

readablity/parameter_name code styl checker rule.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/MiniBrowser/wpe/qt/main.qml (modified) (1 diff)
• Tools/Scripts/webkitpy/style/checker.py (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-30  Philippe Normand  <pnormand@igalia.com>
+
+        [WPE][Qt] loadingChanged signal parameter is unusable
+        https://bugs.webkit.org/show_bug.cgi?id=201301
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/API/wpe/qt/WPEQtView.h: Explicitely name signal
+        parameter. It is a runtime requirement for QML.
+
 2019-08-29  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h

@@ -78 +78 @@
     void urlChanged();
     void titleChanged();
-    void loadingChanged(WPEQtViewLoadRequest*);
+    void loadingChanged(WPEQtViewLoadRequest* loadRequest);
     void loadProgressChanged();
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-30  Philippe Normand  <pnormand@igalia.com>
+
+        [WPE][Qt] loadingChanged signal parameter is unusable
+        https://bugs.webkit.org/show_bug.cgi?id=201301
+
+        Reviewed by Carlos Garcia Campos.
+
+        * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
+        * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
+        readablity/parameter_name code styl checker rule.
+
 2019-08-29  Keith Rollin  <krollin@apple.com>
 

trunk/Tools/MiniBrowser/wpe/qt/main.qml

@@ -17 +17 @@
             main_window.title = title;
         }
+        onLoadingChanged: {
+            if (loadRequest.errorString)
+                console.log('WPEView error: ' + loadRequest.errorString)
+        }
     }
 }

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -153 +153 @@
       os.path.join('Tools', 'TestWebKitAPI')],
      ["-readability/naming"]),
+
+    ([
+      # The WPEQtView class can't rely on the readability/parameter_name rule,
+      # because omitting parameter names for QML signals leads to runtime
+      # errors.
+      os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt', 'WPEQtView.h'),
+    ],
+    ["-readability/parameter_name"]),
 
     ([