Changeset 249332 in webkit


Ignore:
Timestamp:
Aug 30, 2019 10:17:20 AM (5 years ago)
Author:
aboya@igalia.com
Message:

[MSE][GStreamer] Replaying the video should update currentTime
​https://bugs.webkit.org/show_bug.cgi?id=201307

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

  • web-platform-tests/media-source/mediasource-replay-expected.txt: Added.
  • web-platform-tests/media-source/mediasource-replay.html: Added.

Source/WebCore:

While writing a test to confirm that ​https://bugs.webkit.org/show_bug.cgi?id=190050
has indeed been fixed I noticed a non-conformity: when the video has
ended, right after calling .play() for a second playback currentTime
did not return zero, but the video duration.

This turned to be due to the m_isEndReached flag not being reseted on
seeks (replaying a video incurs in a seek done from multi-platform
code).

Test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::seek):

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r249320 r249332  
     12019-08-30  Alicia Boya García  <aboya@igalia.com>
     2
     3        [MSE][GStreamer] Replaying the video should update currentTime
     4        https://bugs.webkit.org/show_bug.cgi?id=201307
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        * web-platform-tests/media-source/mediasource-replay-expected.txt: Added.
     9        * web-platform-tests/media-source/mediasource-replay.html: Added.
     10
    1112019-08-30  Joonghun Park  <jh718.park@samsung.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r249331 r249332  
     12019-08-30  Alicia Boya García  <aboya@igalia.com>
     2
     3        [MSE][GStreamer] Replaying the video should update currentTime
     4        https://bugs.webkit.org/show_bug.cgi?id=201307
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        While writing a test to confirm that https://bugs.webkit.org/show_bug.cgi?id=190050
     9        has indeed been fixed I noticed a non-conformity: when the video has
     10        ended, right after calling .play() for a second playback currentTime
     11        did not return zero, but the video duration.
     12
     13        This turned to be due to the m_isEndReached flag not being reseted on
     14        seeks (replaying a video incurs in a seek done from multi-platform
     15        code).
     16
     17        Test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html
     18
     19        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
     20        (WebCore::MediaPlayerPrivateGStreamerMSE::seek):
     21
    1222019-08-30  Zalan Bujtas  <zalan@apple.com>
    223

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

    r249205 r249332  
    145145void MediaPlayerPrivateGStreamerMSE::seek(const MediaTime& time)
    146146{
     147    GST_DEBUG_OBJECT(pipeline(), "Seeking to %s", time.toString().utf8().data());
    147148    m_seekTime = time;
    148149    m_seeking = true;
     150    m_isEndReached = false;
    149151
    150152    webKitMediaSrcSeek(WEBKIT_MEDIA_SRC(m_source.get()), toGstClockTime(m_seekTime), m_playbackRate);
Note: See TracChangeset for help on using the changeset viewer.