Changeset 249362 in webkit

Timestamp:

Aug 31, 2019 4:31:33 AM (5 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] LLInt op should not emit the same code three times
​https://bugs.webkit.org/show_bug.cgi?id=201370

Reviewed by Mark Lam.

LLInt op macro (not llintOp macro) is used to generate some stub code like llint_program_prologue.
But now it generates the same code three times for narrow, wide16, and wide32. We should emit code only once.

• llint/LowLevelInterpreter.asm:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• llint/LowLevelInterpreter.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-08-30  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] LLInt op should not emit the same code three times
+        https://bugs.webkit.org/show_bug.cgi?id=201370
+
+        Reviewed by Mark Lam.
+
+        LLInt op macro (not llintOp macro) is used to generate some stub code like llint_program_prologue.
+        But now it generates the same code three times for narrow, wide16, and wide32. We should emit code only once.
+
+        * llint/LowLevelInterpreter.asm:
+
 2019-08-30  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

@@ -387 +387 @@
 
 macro op(l, fn)
-    commonOp(l, macro () end, macro (unused)
-        fn()
+    commonOp(l, macro () end, macro (size)
+        size(fn, macro() end, macro() end, macro(gen) gen() end)
     end)
 end