Changeset 249436 in webkit
- Timestamp:
- Sep 3, 2019 11:56:10 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r249431 r249436 1 2019-09-03 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Enable WebAuthn by default for MobileSafari and SafariViewService 4 https://bugs.webkit.org/show_bug.cgi?id=201369 5 <rdar://problem/54903724> 6 7 Reviewed by Brent Fulgham. 8 9 * http/wpt/webauthn/public-key-credential-get-success-nfc.https.html: 10 Imporves the test a bit. 11 1 12 2019-09-03 Antoine Quint <graouts@apple.com> 2 13 -
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-nfc.https.html
r249059 r249436 26 26 publicKey: { 27 27 challenge: Base64URL.parse("MTIzNDU2"), 28 allowCredentials: [{ type: "public-key", id: Base64URL.parse(testU2fCredentialIdBase64) }],28 allowCredentials: [{ type: "public-key", id: Base64URL.parse(testU2fCredentialIdBase64), transports: ["nfc"] }], 29 29 timeout: 100 30 30 } -
trunk/Source/WebCore/ChangeLog
r249434 r249436 1 2019-09-03 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Enable WebAuthn by default for MobileSafari and SafariViewService 4 https://bugs.webkit.org/show_bug.cgi?id=201369 5 <rdar://problem/54903724> 6 7 Reviewed by Brent Fulgham. 8 9 * platform/RuntimeApplicationChecks.h: 10 * platform/cocoa/RuntimeApplicationChecksCocoa.mm: 11 (WebCore::IOSApplication::isSafariViewService): 12 Adds a way to detect SafariViewService. 13 1 14 2019-09-03 Simon Fraser <simon.fraser@apple.com> 2 15 -
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
r249140 r249436 80 80 WEBCORE_EXPORT bool isMailCompositionService(); 81 81 WEBCORE_EXPORT bool isMobileSafari(); 82 WEBCORE_EXPORT bool isSafariViewService(); 82 83 WEBCORE_EXPORT bool isIMDb(); 83 84 WEBCORE_EXPORT bool isWebBookmarksD(); -
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
r249140 r249436 215 215 } 216 216 217 bool IOSApplication::isSafariViewService() 218 { 219 static bool isSafariViewService = applicationBundleIsEqualTo("com.apple.SafariViewService"_s); 220 return isSafariViewService; 221 } 222 217 223 bool IOSApplication::isIMDb() 218 224 { -
trunk/Source/WebKit/ChangeLog
r249435 r249436 1 2019-09-03 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Enable WebAuthn by default for MobileSafari and SafariViewService 4 https://bugs.webkit.org/show_bug.cgi?id=201369 5 <rdar://problem/54903724> 6 7 Reviewed by Brent Fulgham. 8 9 Communications to security keys require entitlements, which are not guaranteed to be present in third party 10 WKWebView clients. Therefore, only enable WebAuthn by default for MobileSafari and SafariViewService. 11 12 * Shared/WebPreferences.yaml: 13 * Shared/WebPreferencesDefaultValues.cpp: 14 (WebKit::defaultWebAuthenticationEnabled): 15 * Shared/WebPreferencesDefaultValues.h: 16 1 17 2019-09-03 Chris Dumez <cdumez@apple.com> 2 18 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r248960 r249436 768 768 WebAuthenticationEnabled: 769 769 type: bool 770 defaultValue: DEFAULT_WEB_AUTHENTICATION_ENABLED770 defaultValue: defaultWebAuthenticationEnabled() 771 771 humanReadableName: "Web Authentication" 772 772 humanReadableDescription: "Enable Web Authentication support" -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
r248697 r249436 78 78 #endif // ENABLE(TEXT_AUTOSIZING) && !PLATFORM(IOS_FAMILY) 79 79 80 bool defaultWebAuthenticationEnabled() 81 { 82 #if PLATFORM(IOS_FAMILY) 83 return WebCore::IOSApplication::isMobileSafari() || WebCore::IOSApplication::isSafariViewService(); 84 #elif PLATFORM(MAC) 85 return true; 86 #else 87 return false; 88 #endif 89 } 90 80 91 } // namespace WebKit -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
r248697 r249436 271 271 #endif 272 272 273 #if PLATFORM(MAC)274 #define DEFAULT_WEB_AUTHENTICATION_ENABLED true275 #else276 #define DEFAULT_WEB_AUTHENTICATION_ENABLED false277 #endif278 279 273 namespace WebKit { 280 274 … … 287 281 #endif 288 282 283 bool defaultWebAuthenticationEnabled(); 284 289 285 } // namespace WebKit
Note: See TracChangeset
for help on using the changeset viewer.