Changeset 249460 in webkit


Ignore:
Timestamp:
Sep 4, 2019 1:14:48 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION (r249364): Layout Test webgpu/texture-triangle-strip.html is Failing
https://bugs.webkit.org/show_bug.cgi?id=201425

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-09-04
Reviewed by Myles C. Maxfield.

The orientation of webgpu/resources/blue-checkered.png is OriginRightTop.
Because r249364 made the image orientation respected everywhere including
the canvas drawImage(), the expected result does not match the output of
the test anymore.

The fix is to change the the expected result to match the image drawing
when the image orientation is respected.

  • webgpu/js/webgpu-functions.js:

(drawGreenAndBlueCheckerboardInSoftware):

Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r249453 r249460  
     12019-09-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        REGRESSION (r249364): Layout Test webgpu/texture-triangle-strip.html is Failing
     4        https://bugs.webkit.org/show_bug.cgi?id=201425
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        The orientation of webgpu/resources/blue-checkered.png is OriginRightTop.
     9        Because r249364 made the image orientation respected everywhere including
     10        the canvas drawImage(), the expected result does not match the output of
     11        the test anymore.
     12
     13        The fix is to change the the expected result to match the image drawing
     14        when the image orientation is respected.
     15
     16        * webgpu/js/webgpu-functions.js:
     17        (drawGreenAndBlueCheckerboardInSoftware):
     18
    1192019-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
    220
  • trunk/LayoutTests/webgpu/js/webgpu-functions.js

    r247764 r249460  
    3939    for (let x = 0; x < numColumns; ++x) {
    4040        for (let y = 0; y < numRows; ++y) {
    41             if (x % 2 == 0 && y % 2 == 0 || x % 2 == 1 && y % 2 == 1)
     41            if ((x + y) % 2 == 1)
    4242                context.rect(
    4343                    x * canvas.width / numColumns,
Note: See TracChangeset for help on using the changeset viewer.