Changeset 249477 in webkit

Timestamp:

Sep 4, 2019 2:04:50 AM (5 years ago)

Author:

Philippe Normand

Message:

[GStreamer] Sound is down-pitched when playing video from YLE Areena
​https://bugs.webkit.org/show_bug.cgi?id=201399

Reviewed by Xabier Rodriguez-Calvar.

If the FDK-AAC decoder is available, promote it and downrank the
libav AAC decoders, due to their broken LC support, as reported in:
​https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247063.html

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/GStreamerCommon.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-04  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Sound is down-pitched when playing video from YLE Areena
+        https://bugs.webkit.org/show_bug.cgi?id=201399
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        If the FDK-AAC decoder is available, promote it and downrank the
+        libav AAC decoders, due to their broken LC support, as reported in:
+        https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247063.html
+
+        * platform/graphics/gstreamer/GStreamerCommon.cpp:
+        (WebCore::initializeGStreamer):
+
 2019-09-04  Pablo Saavedra  <psaavedra@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

@@ -254 +254 @@
             gst_mpegts_initialize();
 #endif
+
+        // If the FDK-AAC decoder is available, promote it and downrank the
+        // libav AAC decoders, due to their broken LC support, as reported in:
+        // https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247063.html
+        GRefPtr<GstElement> aacDecoder = adoptGRef(gst_element_factory_make("fdkaacdec", nullptr));
+        if (aacDecoder) {
+            GstElementFactory* factory = gst_element_get_factory(aacDecoder.get());
+            gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(factory), GST_RANK_PRIMARY);
+
+            const char* const elementNames[] = {"avdec_aac", "avdec_aac_fixed", "avdec_aac_latm"};
+            for (unsigned i = 0; i < G_N_ELEMENTS(elementNames); i++) {
+                GRefPtr<GstElement> avAACDecoder = adoptGRef(gst_element_factory_make(elementNames[i], nullptr));
+                if (avAACDecoder)
+                    gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(gst_element_get_factory(avAACDecoder.get())), GST_RANK_MARGINAL);
+            }
+        }
+
 #endif
     });