Changeset 249480 in webkit

Timestamp:

Sep 4, 2019 8:19:11 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Allow checking whether image was created from JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=200662

Patch by Rob Buis <​rbuis@igalia.com> on 2019-09-04
Reviewed by Darin Adler.

No behavior change.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::create):

• html/HTMLImageElement.h:

(WebCore::HTMLImageElement::createdByParser const):

• html/HTMLTagNames.in:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLImageElement.cpp (modified) (3 diffs)
• html/HTMLImageElement.h (modified) (3 diffs)
• html/HTMLTagNames.in (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-04  Rob Buis  <rbuis@igalia.com>
+
+        Allow checking whether image was created from JavaScript
+        https://bugs.webkit.org/show_bug.cgi?id=200662
+
+        Reviewed by Darin Adler.
+
+        No behavior change.
+
+        * html/HTMLImageElement.cpp:
+        (WebCore::HTMLImageElement::HTMLImageElement):
+        (WebCore::HTMLImageElement::create):
+        * html/HTMLImageElement.h:
+        (WebCore::HTMLImageElement::createdByParser const):
+        * html/HTMLTagNames.in:
+
 2019-09-04  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/html/HTMLImageElement.cpp

@@ -69 +69 @@
 using namespace HTMLNames;
 
-HTMLImageElement::HTMLImageElement(const QualifiedName& tagName, Document& document, HTMLFormElement* form)
+HTMLImageElement::HTMLImageElement(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser)
     : HTMLElement(tagName, document)
     , m_imageLoader(*this)
@@ -77 +77 @@
     , m_imageDevicePixelRatio(1.0f)
     , m_experimentalImageMenuEnabled(false)
+    , m_createdByParser(createdByParser)
 {
     ASSERT(hasTagName(imgTag));
@@ -87 +88 @@
 }
 
-Ref<HTMLImageElement> HTMLImageElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form)
-{
-    return adoptRef(*new HTMLImageElement(tagName, document, form));
+Ref<HTMLImageElement> HTMLImageElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser)
+{
+    return adoptRef(*new HTMLImageElement(tagName, document, form, createdByParser));
 }
 

trunk/Source/WebCore/html/HTMLImageElement.h

@@ -45 +45 @@
 public:
     static Ref<HTMLImageElement> create(Document&);
-    static Ref<HTMLImageElement> create(const QualifiedName&, Document&, HTMLFormElement*);
+    static Ref<HTMLImageElement> create(const QualifiedName&, Document&, HTMLFormElement* = nullptr, bool createdByParser = false);
     static Ref<HTMLImageElement> createForJSConstructor(Document&, Optional<unsigned> width, Optional<unsigned> height);
 
@@ -124 +124 @@
     void defaultEventHandler(Event&) final;
 
+    bool createdByParser() const { return m_createdByParser; }
+
 protected:
-    HTMLImageElement(const QualifiedName&, Document&, HTMLFormElement* = 0);
+    HTMLImageElement(const QualifiedName&, Document&, HTMLFormElement* = nullptr, bool createdByParser = false);
 
     void didMoveToNewDocument(Document& oldDocument, Document& newDocument) override;
@@ -186 +188 @@
     bool m_experimentalImageMenuEnabled;
     bool m_hadNameBeforeAttributeChanged { false }; // FIXME: We only need this because parseAttribute() can't see the old value.
+    bool m_createdByParser { false };
 
     RefPtr<EditableImageReference> m_editableImage;

trunk/Source/WebCore/html/HTMLTagNames.in

@@ -69 +69 @@
 iframe interfaceName=HTMLIFrameElement
 image interfaceName=HTMLUnknownElement
-img interfaceName=HTMLImageElement, constructorNeedsFormElement
+img interfaceName=HTMLImageElement, constructorNeedsFormElement, constructorNeedsCreatedByParser
 input constructorNeedsFormElement, constructorNeedsCreatedByParser
 ins interfaceName=HTMLModElement