Changeset 249489 in webkit


Ignore:
Timestamp:
Sep 4, 2019 11:28:12 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Address review comments after r249364
​https://bugs.webkit.org/show_bug.cgi?id=201432

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-04
Reviewed by Simon Fraser.

Fix the <img> CSS width properties by adding the "px" units.

  • fast/images/exif-orientation-background-expected.html:
  • fast/images/exif-orientation-canvas-expected.html:
  • fast/images/exif-orientation-canvas.html:
  • fast/images/exif-orientation-composited-expected.html:
  • fast/images/exif-orientation-composited.html:

Remove the CSS border to enable the composited image code path.

  • fast/images/exif-orientation-content-expected.html:
  • fast/images/exif-orientation-element-expected.html:
  • fast/images/exif-orientation-element.html:
  • fast/images/exif-orientation-image-document-expected.html:
  • fast/images/exif-orientation-image-document.html:
  • fast/images/exif-orientation-image-object-expected.html:
  • fast/images/exif-orientation-image-object.html:
  • fast/images/exif-orientation-svg-feimage-expected.html:
  • fast/images/exif-orientation-svg-feimage.html:
  • fast/images/exif-orientation-svg-image-expected.html:
  • fast/images/exif-orientation-svg-image.html:
Location:
trunk/LayoutTests
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249460 r249489  
     12019-09-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Address review comments after r249364
     4        https://bugs.webkit.org/show_bug.cgi?id=201432
     5
     6        Reviewed by Simon Fraser.
     7
     8        Fix the <img> CSS width properties by adding the "px" units.
     9
     10        * fast/images/exif-orientation-background-expected.html:
     11        * fast/images/exif-orientation-canvas-expected.html:
     12        * fast/images/exif-orientation-canvas.html:
     13        * fast/images/exif-orientation-composited-expected.html:
     14        * fast/images/exif-orientation-composited.html:
     15        Remove the CSS border to enable the composited image code path.
     16
     17        * fast/images/exif-orientation-content-expected.html:
     18        * fast/images/exif-orientation-element-expected.html:
     19        * fast/images/exif-orientation-element.html:
     20        * fast/images/exif-orientation-image-document-expected.html:
     21        * fast/images/exif-orientation-image-document.html:
     22        * fast/images/exif-orientation-image-object-expected.html:
     23        * fast/images/exif-orientation-image-object.html:
     24        * fast/images/exif-orientation-svg-feimage-expected.html:
     25        * fast/images/exif-orientation-svg-feimage.html:
     26        * fast/images/exif-orientation-svg-image-expected.html:
     27        * fast/images/exif-orientation-svg-image.html:
     28
    1292019-09-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
    230

  • trunk/LayoutTests/fast/images/exif-orientation-background-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-canvas-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-canvas.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-composited-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
    12         height: 52px;
     11        width: 100px;
     12        height: 50px;
    1313    }
    1414    div.vertical {
    15         width: 52px;
    16         height: 102px;
    17     }
    18     img {
    19         border: 1px solid black;
     15        width: 50px;
     16        height: 100px;
    2017    }
    2118</style>
    … …  
    2421    <br>
    2522    <br>
    26     <div class="container">
    27         <div class="horizontal">
    28             <img id="img1" src="resources/exif-orientation-1-ul.jpg">
    29         </div>
    30         <br>Normal
    31     </div>
    3223    <div class="container">
    3324        <div class="horizontal">
    … …  
    7465    </div>
    7566    <br>
    76     <div class="container">
    77         <div class="horizontal">
    78             <img id="img9" src="resources/exif-orientation-1-ul.jpg">
    79         </div>
    80         <br>Undefined (invalid value)
    81     </div>
    82     <br>
    8367    <ul id="console"></ul>
    8468    <script>
    … …  
    9983
    10084         window.addEventListener('load', (event) => {
    101             for(var i = 1; i <= 9; i++)
     85            for(var i = 2; i <= 8; i++)
    10286                log("img" + i + " size = " + imageSize(i));
    10387        });

  • trunk/LayoutTests/fast/images/exif-orientation-composited.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
    12         height: 52px;
     11        width: 100px;
     12        height: 50px;
    1313    }
    1414    div.vertical {
    15         width: 52px;
    16         height: 102px;
     15        width: 50px;
     16        height: 100px;
    1717    }
    1818    img {
    1919        -webkit-transform: translateZ(0);
    20         border: 1px solid black;
    2120    }
    2221</style>
    … …  
    2524    <br>
    2625    <br>
    27     <div class="container">
    28         <div class="horizontal">
    29             <img id="img1" src="resources/exif-orientation-1-ul.jpg">
    30         </div>
    31         <br>Normal
    32     </div>
    3326    <div class="container">
    3427        <div class="horizontal">
    … …  
    7568    </div>
    7669    <br>
    77     <div class="container">
    78         <div class="horizontal">
    79             <img id="img9" src="resources/exif-orientation-9-u.jpg">
    80         </div>
    81         <br>Undefined (invalid value)
    82     </div>
    83     <br>
    8470    <ul id="console"></ul>
    8571    <script>
    … …  
    9783
    9884         window.addEventListener('load', (event) => {
    99             for(var i = 1; i <= 9; i++)
     85            for(var i = 2; i <= 8; i++)
    10086                log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
    10187        });

  • trunk/LayoutTests/fast/images/exif-orientation-content-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-element-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-element.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-image-document-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-image-document.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-image-object-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-image-object.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-svg-feimage-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-svg-feimage.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-svg-image-expected.html

    r249364 r249489  
    99    }
    1010    div.horizontal {
    11         width: 102;
     11        width: 102px;
    1212        height: 52px;
    1313    }

  • trunk/LayoutTests/fast/images/exif-orientation-svg-image.html

    r249364 r249489  
    1010
    1111    div.horizontal {
    12         width: 102;
     12        width: 102px;
    1313        height: 52px;
    1414    }
Note: See TracChangeset for help on using the changeset viewer.