Changeset 249507 in webkit
- Timestamp:
- Sep 4, 2019 6:02:17 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r249504 r249507 1 2019-09-04 Tim Horton <timothy_horton@apple.com> 2 3 Line artifacts in note body after viewing note with <attachment>s 4 https://bugs.webkit.org/show_bug.cgi?id=201474 5 <rdar://problem/51306108> 6 7 Reviewed by Simon Fraser. 8 9 * fast/attachment/attachment-border-should-stay-inside-attachment-expected.html: Added. 10 * fast/attachment/attachment-border-should-stay-inside-attachment.html: Added. 11 Add a test that ensures that <attachment> stays inside its bounds. 12 1 13 2019-09-04 Joseph Pecoraro <pecoraro@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r249504 r249507 1 2019-09-04 Tim Horton <timothy_horton@apple.com> 2 3 Line artifacts in note body after viewing note with <attachment>s 4 https://bugs.webkit.org/show_bug.cgi?id=201474 5 <rdar://problem/51306108> 6 7 Reviewed by Simon Fraser. 8 9 Test: fast/attachment/attachment-border-should-stay-inside-attachment.html 10 11 * rendering/RenderThemeIOS.mm: 12 (WebCore::attachmentBorderPath): 13 (WebCore::paintAttachmentBorder): 14 Inset the border rect by half the width, so that <attachment> doesn't 15 paint out-of-bounds. 16 1 17 2019-09-04 Joseph Pecoraro <pecoraro@apple.com> 2 18 -
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
r248648 r249507 1530 1530 const CGFloat attachmentBorderRadius = 16; 1531 1531 static Color attachmentBorderColor() { return Color(204, 204, 204); } 1532 static CGFloat attachmentBorderThickness = 1; 1532 1533 1533 1534 static Color attachmentProgressColor() { return Color(222, 222, 222); } … … 1840 1841 static Path attachmentBorderPath(RenderAttachmentInfo& info) 1841 1842 { 1843 auto insetAttachmentRect = info.attachmentRect; 1844 insetAttachmentRect.inflate(-attachmentBorderThickness / 2); 1845 1842 1846 Path borderPath; 1843 borderPath.addRoundedRect(in fo.attachmentRect, FloatSize(attachmentBorderRadius, attachmentBorderRadius));1847 borderPath.addRoundedRect(insetAttachmentRect, FloatSize(attachmentBorderRadius, attachmentBorderRadius)); 1844 1848 return borderPath; 1845 1849 } … … 1848 1852 { 1849 1853 context.setStrokeColor(attachmentBorderColor()); 1850 context.setStrokeThickness( 1);1854 context.setStrokeThickness(attachmentBorderThickness); 1851 1855 context.strokePath(borderPath); 1852 1856 }
Note: See TracChangeset
for help on using the changeset viewer.