Changeset 249600 in webkit

Timestamp:

Sep 6, 2019 5:08:13 PM (5 years ago)

Author:

jiewen_tan@apple.com

Message:

[WebAuthn] Make WebAuthn default off and let clients turn it on at will
​https://bugs.webkit.org/show_bug.cgi?id=201439
<rdar://problem/54998154>

Reviewed by Youenn Fablet.

This patch makes WebAuthn default off such that clients that have the right entitlements
could turn it on and we don't risk at turning on a Web API that does nothing by default.

This patch doesn't add any SPI to turn the feature on as it is currently doable via

• [WKPreferencesPrivate _setEnabled:forExperimentalFeature:].

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWebAuthenticationEnabled): Deleted.

• Shared/WebPreferencesDefaultValues.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferences.yaml (modified) (1 diff)
• Shared/WebPreferencesDefaultValues.cpp (modified) (1 diff)
• Shared/WebPreferencesDefaultValues.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-06  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [WebAuthn] Make WebAuthn default off and let clients turn it on at will
+        https://bugs.webkit.org/show_bug.cgi?id=201439
+        <rdar://problem/54998154>
+
+        Reviewed by Youenn Fablet.
+
+        This patch makes WebAuthn default off such that clients that have the right entitlements
+        could turn it on and we don't risk at turning on a Web API that does nothing by default.
+
+        This patch doesn't add any SPI to turn the feature on as it is currently doable via
+        - [WKPreferencesPrivate _setEnabled:forExperimentalFeature:].
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultWebAuthenticationEnabled): Deleted.
+        * Shared/WebPreferencesDefaultValues.h:
+
 2019-09-06  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -768 +768 @@
 WebAuthenticationEnabled:
   type: bool
-  defaultValue: defaultWebAuthenticationEnabled()
+  defaultValue: false
   humanReadableName: "Web Authentication"
   humanReadableDescription: "Enable Web Authentication support"

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@ -65 +65 @@
 #endif // ENABLE(TEXT_AUTOSIZING) && !PLATFORM(IOS_FAMILY)
 
-bool defaultWebAuthenticationEnabled()
-{
-#if PLATFORM(IOS_FAMILY)
-    return WebCore::IOSApplication::isMobileSafari() || WebCore::IOSApplication::isSafariViewService();
-#elif PLATFORM(MAC)
-    return true;
-#else
-    return false;
-#endif
-}
-
 } // namespace WebKit

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

@@ -286 +286 @@
 #endif
 
-bool defaultWebAuthenticationEnabled();
-
 } // namespace WebKit