Changeset 249653 in webkit

Timestamp:

Sep 9, 2019 11:56:47 AM (5 years ago)

Author:

dbates@webkit.org

Message:

Remove all selection view animations before dumping results
​https://bugs.webkit.org/show_bug.cgi?id=199241

Reviewed by Wenson Hsieh.

On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
historical tests that were written for Mac and expect Mac's lack of animations that we run on
iOS and are flaky. Let's try to remove all selection view animations before dumping results and
see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
API for a test to remove selection animations at any time during the run.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::notifyDone):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/ios/TestControllerIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-09-09  Daniel Bates  <dabates@apple.com>
+
+        Remove all selection view animations before dumping results
+        https://bugs.webkit.org/show_bug.cgi?id=199241
+
+        Reviewed by Wenson Hsieh.
+
+        On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
+        historical tests that were written for Mac and expect Mac's lack of animations that we run on
+        iOS and are flaky. Let's try to remove all selection view animations before dumping results and
+        see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
+        API for a test to remove selection animations at any time during the run.
+
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::TestController::notifyDone):
+
 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm

@@ -83 +83 @@
 void TestController::notifyDone()
 {
+    UIView *contentView = [mainWebView()->platformView() valueForKeyPath:@"_currentContentView"];
+    UIView *selectionView = [contentView valueForKeyPath:@"interactionAssistant.selectionView"];
+    [selectionView _removeAllAnimations:YES];
 }