Changeset 249663 in webkit


Ignore:
Timestamp:
Sep 9, 2019 1:36:13 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
https://bugs.webkit.org/show_bug.cgi?id=201607

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-build/steps.py

    r249355 r249663  
    13581358        clean_tree_results = self.results.get(RunAPITestsWithoutPatch.name)
    13591359
    1360         if not (first_run_results and second_run_results and clean_tree_results):
     1360        if not (first_run_results and second_run_results):
    13611361            self.finished(RETRY)
    13621362            self.build.buildFinished(['Unable to parse API test results'], RETRY)
     
    13641364
    13651365        def getAPITestFailures(result):
     1366            if not result:
     1367                return set([])
    13661368            # TODO: Analyze Time-out, Crash and Failure independently
    13671369            return set([failure.get('name') for failure in result.get('Timedout', [])] +
  • trunk/Tools/ChangeLog

    r249661 r249663  
     12019-09-09  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
     4        https://bugs.webkit.org/show_bug.cgi?id=201607
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-build/steps.py:
     9        (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
     10        (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
     11
    1122019-09-07  Keith Miller  <keith_miller@apple.com>
    213
Note: See TracChangeset for help on using the changeset viewer.