Changeset 249729 in webkit

Timestamp:

Sep 10, 2019 12:42:30 PM (5 years ago)

Author:

sihui_liu@apple.com

Message:

IndexedDB: cache prepared SQLiteStatement in SQLiteIDBCursor
​https://bugs.webkit.org/show_bug.cgi?id=201548

Reviewed by Alex Christensen.

This should be a performance improvement as we don't compile the same SQLiteStatement everytime it is used.

No new tests, no behavior change.

• Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):

• Modules/indexeddb/server/SQLiteIDBCursor.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/SQLiteIDBCursor.cpp (modified) (2 diffs)
• Modules/indexeddb/server/SQLiteIDBCursor.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-10  Sihui Liu  <sihui_liu@apple.com>
+
+        IndexedDB: cache prepared SQLiteStatement in SQLiteIDBCursor
+        https://bugs.webkit.org/show_bug.cgi?id=201548
+
+        Reviewed by Alex Christensen.
+
+        This should be a performance improvement as we don't compile the same SQLiteStatement everytime it is used.
+
+        No new tests, no behavior change.
+
+        * Modules/indexeddb/server/SQLiteIDBCursor.cpp:
+        (WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):
+        * Modules/indexeddb/server/SQLiteIDBCursor.h:
+
 2019-09-10  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp

@@ -473 +473 @@
         }
 
-        SQLiteStatement objectStoreStatement(m_statement->database(), "SELECT value FROM Records WHERE key = CAST(? AS TEXT) and objectStoreID = ?;");
-
-        if (objectStoreStatement.prepare() != SQLITE_OK
-            || objectStoreStatement.bindBlob(1, keyData.data(), keyData.size()) != SQLITE_OK
-            || objectStoreStatement.bindInt64(2, m_objectStoreID) != SQLITE_OK) {
+        if (!m_cachedObjectStoreStatement || m_cachedObjectStoreStatement->reset() != SQLITE_OK) {
+            m_cachedObjectStoreStatement = makeUnique<SQLiteStatement>(m_statement->database(), "SELECT value FROM Records WHERE key = CAST(? AS TEXT) and objectStoreID = ?;");
+            if (m_cachedObjectStoreStatement->prepare() != SQLITE_OK)
+                m_cachedObjectStoreStatement = nullptr;
+        }
+
+        if (!m_cachedObjectStoreStatement
+            || m_cachedObjectStoreStatement->bindBlob(1, keyData.data(), keyData.size()) != SQLITE_OK
+            || m_cachedObjectStoreStatement->bindInt64(2, m_objectStoreID) != SQLITE_OK) {
             LOG_ERROR("Could not create index cursor statement into object store records (%i) '%s'", m_statement->database().lastError(), m_statement->database().lastErrorMsg());
             markAsErrored(record);
@@ -483 +487 @@
         }
 
-        int result = objectStoreStatement.step();
+        int result = m_cachedObjectStoreStatement->step();
 
         if (result == SQLITE_ROW) {
-            objectStoreStatement.getColumnBlobAsVector(0, keyData);
+            m_cachedObjectStoreStatement->getColumnBlobAsVector(0, keyData);
             record.record.value = makeUnique<IDBValue>(ThreadSafeDataBuffer::create(WTFMove(keyData)));
         } else if (result == SQLITE_DONE) {

trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.h

@@ -124 +124 @@
 
     std::unique_ptr<SQLiteStatement> m_statement;
+    std::unique_ptr<SQLiteStatement> m_cachedObjectStoreStatement;
+
     bool m_statementNeedsReset { true };
     int64_t m_boundID { 0 };