Changeset 249755 in webkit


Ignore:
Timestamp:
Sep 10, 2019 11:06:53 PM (5 years ago)
Author:
Fujii Hironori
Message:

[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
https://bugs.webkit.org/show_bug.cgi?id=192581
<rdar://problem/46651605>

Reviewed by Alex Christensen.

WebKitLegacy COM interfaces have same name methods within the old
and new interfaces. For example, both IWebEditingDelegate and
IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
This is a part of public API, can't be renamed.

  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebViewPrivate.idl:

Added #pragma to ignore the warning.

Location:
trunk/Source/WebKitLegacy/win
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKitLegacy/win/ChangeLog

    r249682 r249755  
     12019-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
     4        https://bugs.webkit.org/show_bug.cgi?id=192581
     5        <rdar://problem/46651605>
     6
     7        Reviewed by Alex Christensen.
     8
     9        WebKitLegacy COM interfaces have same name methods within the old
     10        and new interfaces. For example, both IWebEditingDelegate and
     11        IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
     12        This is a part of public API, can't be renamed.
     13
     14        * Interfaces/IWebEditingDelegate.idl:
     15        * Interfaces/IWebViewPrivate.idl:
     16        Added #pragma to ignore the warning.
     17
    1182019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
    219
  • trunk/Source/WebKitLegacy/win/Interfaces/IWebEditingDelegate.idl

    r186881 r249755  
    190190}
    191191
     192cpp_quote("#if defined(__GNUC__) || defined(__clang__)")
     193cpp_quote("#pragma GCC diagnostic push")
     194cpp_quote("#pragma GCC diagnostic ignored \"-Woverloaded-virtual\"")
     195cpp_quote("#endif")
     196
    192197[
    193198    uuid(9973D190-3346-4CAA-AB76-F070CAB0B59B)
     
    200205    HRESULT shouldInsertNode([in] IWebView* webView, [in] IDOMNode* node, [in] IDOMRange* range, [in] WebViewInsertAction action, [out, retval] BOOL* result);
    201206}
     207
     208cpp_quote("#if defined(__GNUC__) || defined(__clang__)")
     209cpp_quote("#pragma GCC diagnostic pop")
     210cpp_quote("#endif")
  • trunk/Source/WebKitLegacy/win/Interfaces/IWebViewPrivate.idl

    r217557 r249755  
    298298}
    299299
     300cpp_quote("#if defined(__GNUC__) || defined(__clang__)")
     301cpp_quote("#pragma GCC diagnostic push")
     302cpp_quote("#pragma GCC diagnostic ignored \"-Woverloaded-virtual\"")
     303cpp_quote("#endif")
     304
    300305[ uuid(671FB259-ABEF-48FC-88FB-EC4CF304E866) ]
    301306interface IWebViewPrivate2 : IWebViewPrivate
     
    321326        [in] WebUserContentInjectedFrames injectedFrames);
    322327}
     328
     329cpp_quote("#if defined(__GNUC__) || defined(__clang__)")
     330cpp_quote("#pragma GCC diagnostic pop")
     331cpp_quote("#endif")
    323332
    324333typedef enum {
Note: See TracChangeset for help on using the changeset viewer.