Changeset 249755 in webkit
- Timestamp:
- Sep 10, 2019 11:06:53 PM (5 years ago)
- Location:
- trunk/Source/WebKitLegacy/win
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKitLegacy/win/ChangeLog
r249682 r249755 1 2019-09-10 Fujii Hironori <Hironori.Fujii@sony.com> 2 3 [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual] 4 https://bugs.webkit.org/show_bug.cgi?id=192581 5 <rdar://problem/46651605> 6 7 Reviewed by Alex Christensen. 8 9 WebKitLegacy COM interfaces have same name methods within the old 10 and new interfaces. For example, both IWebEditingDelegate and 11 IWebEditingDelegate2 interfaces have 'shouldInsertNode' method. 12 This is a part of public API, can't be renamed. 13 14 * Interfaces/IWebEditingDelegate.idl: 15 * Interfaces/IWebViewPrivate.idl: 16 Added #pragma to ignore the warning. 17 1 18 2019-09-09 Fujii Hironori <Hironori.Fujii@sony.com> 2 19 -
trunk/Source/WebKitLegacy/win/Interfaces/IWebEditingDelegate.idl
r186881 r249755 190 190 } 191 191 192 cpp_quote("#if defined(__GNUC__) || defined(__clang__)") 193 cpp_quote("#pragma GCC diagnostic push") 194 cpp_quote("#pragma GCC diagnostic ignored \"-Woverloaded-virtual\"") 195 cpp_quote("#endif") 196 192 197 [ 193 198 uuid(9973D190-3346-4CAA-AB76-F070CAB0B59B) … … 200 205 HRESULT shouldInsertNode([in] IWebView* webView, [in] IDOMNode* node, [in] IDOMRange* range, [in] WebViewInsertAction action, [out, retval] BOOL* result); 201 206 } 207 208 cpp_quote("#if defined(__GNUC__) || defined(__clang__)") 209 cpp_quote("#pragma GCC diagnostic pop") 210 cpp_quote("#endif") -
trunk/Source/WebKitLegacy/win/Interfaces/IWebViewPrivate.idl
r217557 r249755 298 298 } 299 299 300 cpp_quote("#if defined(__GNUC__) || defined(__clang__)") 301 cpp_quote("#pragma GCC diagnostic push") 302 cpp_quote("#pragma GCC diagnostic ignored \"-Woverloaded-virtual\"") 303 cpp_quote("#endif") 304 300 305 [ uuid(671FB259-ABEF-48FC-88FB-EC4CF304E866) ] 301 306 interface IWebViewPrivate2 : IWebViewPrivate … … 321 326 [in] WebUserContentInjectedFrames injectedFrames); 322 327 } 328 329 cpp_quote("#if defined(__GNUC__) || defined(__clang__)") 330 cpp_quote("#pragma GCC diagnostic pop") 331 cpp_quote("#endif") 323 332 324 333 typedef enum {
Note: See TracChangeset
for help on using the changeset viewer.