Changeset 249761 in webkit

Timestamp:

Sep 11, 2019 4:49:14 AM (5 years ago)

Author:

cturner@igalia.com

Message:

[GStreamer] Do not adopt floating references.
​https://bugs.webkit.org/show_bug.cgi?id=201685

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer): gst_element_factory_make returns
floating references, you do not adopt such references, rather you
sink them.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/GStreamerCommon.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-11  Charlie Turner  <cturner@igalia.com>
+
+        [GStreamer] Do not adopt floating references.
+        https://bugs.webkit.org/show_bug.cgi?id=201685
+
+        Reviewed by Carlos Garcia Campos.
+
+        Covered by existing tests.
+
+        * platform/graphics/gstreamer/GStreamerCommon.cpp:
+        (WebCore::initializeGStreamer): gst_element_factory_make returns
+        floating references, you do not adopt such references, rather you
+        sink them.
+
 2019-09-11  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

@@ -258 +258 @@
         // libav AAC decoders, due to their broken LC support, as reported in:
         // https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247063.html
-        GRefPtr<GstElement> aacDecoder = adoptGRef(gst_element_factory_make("fdkaacdec", nullptr));
+        GRefPtr<GstElement> aacDecoder = gst_element_factory_make("fdkaacdec", nullptr);
         if (aacDecoder) {
             GstElementFactory* factory = gst_element_get_factory(aacDecoder.get());
@@ -265 +265 @@
             const char* const elementNames[] = {"avdec_aac", "avdec_aac_fixed", "avdec_aac_latm"};
             for (unsigned i = 0; i < G_N_ELEMENTS(elementNames); i++) {
-                GRefPtr<GstElement> avAACDecoder = adoptGRef(gst_element_factory_make(elementNames[i], nullptr));
+                GRefPtr<GstElement> avAACDecoder = gst_element_factory_make(elementNames[i], nullptr);
                 if (avAACDecoder)
                     gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(gst_element_get_factory(avAACDecoder.get())), GST_RANK_MARGINAL);