Changeset 25008 in webkit

Timestamp:

Aug 11, 2007 4:52:44 AM (17 years ago)

Author:

andrew

Message:

LayoutTests:

Reviewed by Mark Rowe.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive

Test for getPropertyValue, setProperty, removeProperty being case-insensitive

• fast/css/css-properties-case-insensitive-expected.txt: Added.
• fast/css/css-properties-case-insensitive.html: Added.

WebCore:

Reviewed by Mark Rowe.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive

When we get the propertyID for a given string we convert to lowercase.

This also applies to setProperty, removeProperty and others.

• css/CSSStyleDeclaration.cpp: (WebCore::propertyID):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/css-properties-case-insensitive-expected.txt (added)
• LayoutTests/fast/css/css-properties-case-insensitive.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSStyleDeclaration.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-08-11  Andrew Wellington  <proton@wiretapped.net>
+
+        Reviewed by Mark Rowe.
+        
+        Fix http://bugs.webkit.org/show_bug.cgi?id=14645
+        getPropertyValue should be case insensitive
+        
+        Test for getPropertyValue, setProperty, removeProperty being case-insensitive
+
+        * fast/css/css-properties-case-insensitive-expected.txt: Added.
+        * fast/css/css-properties-case-insensitive.html: Added.
+
 2007-08-10  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-11  Andrew Wellington  <proton@wiretapped.net>
+
+        Reviewed by Mark Rowe.
+        
+        Fix http://bugs.webkit.org/show_bug.cgi?id=14645
+        getPropertyValue should be case insensitive
+        
+        When we get the propertyID for a given string we convert to lowercase.
+        
+        This also applies to setProperty, removeProperty and others.
+        
+        * css/CSSStyleDeclaration.cpp:
+        (WebCore::propertyID):
+
 2007-08-11  Mark Rowe  <mrowe@apple.com>
 

trunk/WebCore/css/CSSStyleDeclaration.cpp

@@ -30 +30 @@
 #include "DeprecatedValueList.h"
 #include "ksvgcssproperties.h"
+#include <ctype.h>
 
 namespace WebCore {
@@ -48 +49 @@
         if (c == 0 || c >= 0x7F)
             return 0; // illegal character
-        buffer[i] = c;
+        buffer[i] = tolower(c);
     }