Changeset 250395 in webkit


Ignore:
Timestamp:
Sep 26, 2019 1:05:25 PM (5 years ago)
Author:
Truitt Savell
Message:

Unreviewed, rolling out r250385.

Broke imported/w3c/web-platform-tests/svg/animations/syncbase-
remove-add-while-running.html on all platforms. Which was
caught by EWS

Reverted changeset:

"Non-callable "handleEvent" property is silently ignored"
​https://bugs.webkit.org/show_bug.cgi?id=200066
​https://trac.webkit.org/changeset/250385

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r250385 r250395  
     12019-09-26  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r250385.
     4
     5        Broke imported/w3c/web-platform-tests/svg/animations/syncbase-
     6        remove-add-while-running.html on all platforms. Which was
     7        caught by EWS
     8
     9        Reverted changeset:
     10
     11        "Non-callable "handleEvent" property is silently ignored"
     12        https://bugs.webkit.org/show_bug.cgi?id=200066
     13        https://trac.webkit.org/changeset/250385
     14
    1152019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt

    r250385 r250395  
    44PASS Exception in error event listener on request
    55PASS Exception in error event listener ("handleEvent" lookup) on request
    6 PASS Exception in error event listener (non-callable "handleEvent") on request
     6FAIL Exception in error event listener (non-callable "handleEvent") on request assert_equals: expected "AbortError" but got "ConstraintError"
    77PASS Exception in second error event listener on request
    88PASS Exception in first error event listener on request, transaction active in second

  • trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception-expected.txt

    r250385 r250395  
    33PASS Exception in success event listener on request
    44PASS Exception in success event listener ("handleEvent" lookup) on request
    5 PASS Exception in success event listener (non-callable "handleEvent") on request
     5FAIL Exception in success event listener (non-callable "handleEvent") on request assert_unreached: transaction should abort Reached unreachable code
    66PASS Exception in second success event listener on request
    77PASS Exception in first success event listener, tx active in second

  • trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception-expected.txt

    r250385 r250395  
    22CONSOLE MESSAGE: line 37: Error
    33CONSOLE MESSAGE: line 44: Error
    4 CONSOLE MESSAGE: TypeError: 'handleEvent' property of event listener should be callable
    54CONSOLE MESSAGE: line 62: Error
    65CONSOLE MESSAGE: line 70: Error
    … …  
    98PASS Exception in upgradeneeded listener
    109PASS Exception in upgradeneeded "handleEvent" lookup
    11 PASS Exception in upgradeneeded due to non-callable "handleEvent"
     10FAIL Exception in upgradeneeded due to non-callable "handleEvent" assert_unreached: open should fail Reached unreachable code
    1211PASS Exception in second upgradeneeded listener
    1312PASS Exception in first upgradeneeded listener, tx active in second

  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventListener-handleEvent-expected.txt

    r250385 r250395  
    11CONSOLE MESSAGE: line 46: [object Object]
    2 CONSOLE MESSAGE: line 101: TypeError: 'handleEvent' property of event listener should be callable
    3 CONSOLE MESSAGE: line 122: TypeError: 'handleEvent' property of event listener should be callable
    42
    53PASS calls `handleEvent` method of `EventListener`
    … …  
    75PASS performs `Get` every time event is dispatched
    86PASS doesn't call `handleEvent` method on callable `EventListener`
    9 PASS throws if `handleEvent` is falsy and not callable
    10 PASS throws if `handleEvent` is thruthy and not callable
     7FAIL throws if `handleEvent` is falsy and not callable assert_true: expected true got false
     8FAIL throws if `handleEvent` is thruthy and not callable assert_true: expected true got false
    119

  • trunk/Source/WebCore/ChangeLog

    r250393 r250395  
     12019-09-26  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r250385.
     4
     5        Broke imported/w3c/web-platform-tests/svg/animations/syncbase-
     6        remove-add-while-running.html on all platforms. Which was
     7        caught by EWS
     8
     9        Reverted changeset:
     10
     11        "Non-callable "handleEvent" property is silently ignored"
     12        https://bugs.webkit.org/show_bug.cgi?id=200066
     13        https://trac.webkit.org/changeset/250385
     14
    1152019-09-26  Kate Cheney  <katherine_cheney@apple.com>
    216

  • trunk/Source/WebCore/bindings/js/JSEventListener.cpp

    r250385 r250395  
    149149        }
    150150        callType = getCallData(vm, handleEventFunction, callData);
    151         if (callType == CallType::None) {
    152             event.target()->uncaughtExceptionInEventHandler();
    153             reportException(exec, createTypeError(exec, "'handleEvent' property of event listener should be callable"_s));
    154             return;
    155         }
    156     }
     151    }
     152
     153    if (callType == CallType::None)
     154        return;
    157155
    158156    Ref<JSEventListener> protectedThis(*this);
Note: See TracChangeset for help on using the changeset viewer.