Changeset 250754 in webkit
- Timestamp:
- Oct 4, 2019 4:12:45 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r250741 r250754 1 2019-10-04 Chris Dumez <cdumez@apple.com> 2 3 Allow pages using IDBIndex to enter the PageCache 4 https://bugs.webkit.org/show_bug.cgi?id=202430 5 <rdar://problem/55887918> 6 7 Reviewed by Geoffrey Garen. 8 9 Extend layout test coverage. 10 11 * storage/indexeddb/IDBTransaction-page-cache-expected.txt: 12 * storage/indexeddb/IDBTransaction-page-cache.html: 13 1 14 2019-10-04 Truitt Savell <tsavell@apple.com> 2 15 -
trunk/LayoutTests/storage/indexeddb/IDBTransaction-page-cache-expected.txt
r250531 r250754 1 Tests that an IDBRequest does not prevent page caching.1 Tests that an IDBRequest & IDBIndex does not prevent page caching. 2 2 3 3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". … … 5 5 6 6 pageshow - not from page cache 7 PASS !!myIndex is true 7 8 pagehide - entering page cache 8 9 pageshow - from page cache -
trunk/LayoutTests/storage/indexeddb/IDBTransaction-page-cache.html
r250531 r250754 5 5 <script src="../../resources/js-test.js"></script> 6 6 <script> 7 description("Tests that an IDBRequest does not prevent page caching.");7 description("Tests that an IDBRequest & IDBIndex does not prevent page caching."); 8 8 jsTestIsAsync = true; 9 9 … … 36 36 transaction = objectStore.transaction; 37 37 38 myIndex = objectStore.createIndex('index', 'x', {unique: true}); 39 shouldBeTrue("!!myIndex"); 40 38 41 window.location = "../../fast/history/resources/page-cache-helper.html"; 39 42 }; -
trunk/Source/WebCore/ChangeLog
r250747 r250754 1 2019-10-04 Chris Dumez <cdumez@apple.com> 2 3 Allow pages using IDBIndex to enter the PageCache 4 https://bugs.webkit.org/show_bug.cgi?id=202430 5 <rdar://problem/55887918> 6 7 Reviewed by Geoffrey Garen. 8 9 There is no reason to prevent PageCaching when an IDBIndex object is alive. 10 No events are fired by IDBIndex and its API returns IDBRequest objects, which 11 are already PageCache-aware. 12 13 I have seen Yahoo.com failing to enter the back/forward cache because of this. 14 15 No new tests, updated existing test. 16 17 * Modules/indexeddb/IDBIndex.cpp: 18 (WebCore::IDBIndex::canSuspendForDocumentSuspension const): 19 1 20 2019-10-04 Heiko Becker <heirecka@exherbo.org> 2 21 -
trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp
r243039 r250754 65 65 bool IDBIndex::canSuspendForDocumentSuspension() const 66 66 { 67 return false;67 return true; 68 68 } 69 69
Note: See TracChangeset
for help on using the changeset viewer.