Changeset 250787 in webkit


Ignore:
Timestamp:
Oct 7, 2019 1:41:59 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Change Response's statusText's default
​https://bugs.webkit.org/show_bug.cgi?id=191879

Patch by Rob Buis <​rbuis@igalia.com> on 2019-10-07
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

  • web-platform-tests/fetch/api/response/response-clone-expected.txt:
  • web-platform-tests/fetch/api/response/response-init-001-expected.txt:

Source/WebCore:

Change Response's statusText's default to "".

Tests: web-platform-tests/fetch/api/response/response-clone.html

web-platform-tests/fetch/api/response/response-init-001.html

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r250783 r250787  
     12019-10-07  Rob Buis  <rbuis@igalia.com>
     2
     3        Change Response's statusText's default
     4        https://bugs.webkit.org/show_bug.cgi?id=191879
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Update improved test results.
     9
     10        * web-platform-tests/fetch/api/response/response-clone-expected.txt:
     11        * web-platform-tests/fetch/api/response/response-init-001-expected.txt:
     12
    1132019-10-07  Alexey Shvayka  <shvaikalesh@gmail.com>
    214

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt

    r239693 r250787  
    11
    2 FAIL Check Response's clone with default values, without body assert_equals: Expect default response.statusText is  expected "" but got "OK"
     2PASS Check Response's clone with default values, without body
    33PASS Check Response's clone has the expected attribute values
    44PASS Check orginal response's body after cloning

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-001-expected.txt

    r239693 r250787  
    44PASS Check default value for ok attribute
    55PASS Check default value for status attribute
    6 FAIL Check default value for statusText attribute assert_equals: Expect default response.statusText is  expected "" but got "OK"
     6PASS Check default value for statusText attribute
    77PASS Check default value for body attribute
    88PASS Check status init values and associated getter

  • trunk/Source/WebCore/ChangeLog

    r250786 r250787  
     12019-10-07  Rob Buis  <rbuis@igalia.com>
     2
     3        Change Response's statusText's default
     4        https://bugs.webkit.org/show_bug.cgi?id=191879
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Change Response's statusText's default to "".
     9
     10        Tests: web-platform-tests/fetch/api/response/response-clone.html
     11               web-platform-tests/fetch/api/response/response-init-001.html
     12
     13        * Modules/fetch/FetchResponse.h:
     14        * Modules/fetch/FetchResponse.idl:
     15
    1162019-10-07  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/Modules/fetch/FetchResponse.h

    r247087 r250787  
    5454    struct Init {
    5555        unsigned short status { 200 };
    56         String statusText { "OK"_s };
     56        String statusText;
    5757        Optional<FetchHeaders::Init> headers;
    5858    };

  • trunk/Source/WebCore/Modules/fetch/FetchResponse.idl

    r223562 r250787  
    3434dictionary FetchResponseInit {
    3535    unsigned short status = 200;
    36     ByteString statusText = "OK";
     36    ByteString statusText = "";
    3737    HeadersInit headers;
    3838};
Note: See TracChangeset for help on using the changeset viewer.