Changeset 250809 in webkit


Ignore:
Timestamp:
Oct 7, 2019 6:02:45 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
https://bugs.webkit.org/show_bug.cgi?id=199705

Patch by Dan Bernstein and Kenneth Russell.
Patch by Alexey Proskuryakov <ap@apple.com> on 2019-10-07
Reviewed by Alexey Proskuryakov.

Source/WebCore/PAL:

  • pal/spi/mac/NSViewSPI.h: Declare _subviews when we are not using the

replacement SPI, but the SDK doesn't declare the ivar (because the SDK is too new).

Source/WTF:

  • wtf/Platform.h: Added HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK.
Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r250765 r250809  
     12019-10-07  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
     4        https://bugs.webkit.org/show_bug.cgi?id=199705
     5
     6        Patch by Dan Bernstein and Kenneth Russell.
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * wtf/Platform.h: Added HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK.
     10
    1112019-10-04  Commit Queue  <commit-queue@webkit.org>
    212
  • trunk/Source/WTF/wtf/Platform.h

    r250673 r250809  
    16241624#endif
    16251625
     1626#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101500
     1627#define HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK 1
     1628#endif
     1629
    16261630#if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)
    16271631#define USE_PLATFORM_SYSTEM_FALLBACK_LIST 1
  • trunk/Source/WebCore/PAL/ChangeLog

    r250723 r250809  
     12019-10-07  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
     4        https://bugs.webkit.org/show_bug.cgi?id=199705
     5
     6        Patch by Dan Bernstein and Kenneth Russell.
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * pal/spi/mac/NSViewSPI.h: Declare _subviews when we are not using the
     10        replacement SPI, but the SDK doesn't declare the ivar (because the SDK is too new).
     11
    1122019-10-04  Alex Christensen  <achristensen@webkit.org>
    213
  • trunk/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h

    r247117 r250809  
    3030#import <pal/spi/cocoa/QuartzCoreSPI.h>
    3131
    32 @interface NSView () <CALayerDelegate>
     32@interface NSView () <CALayerDelegate> {
     33#if !HAVE(SUBVIEWS_IVAR_SPI) && !HAVE(SUBVIEWS_IVAR_DECLARED_BY_SDK)
     34@package
     35    NSMutableArray<__kindof NSView *> *_subviews;
     36#endif
     37}
    3338
    3439- (NSView *)_findLastViewInKeyViewLoop;
Note: See TracChangeset for help on using the changeset viewer.