Changeset 250813 in webkit

Timestamp:

Oct 7, 2019 9:34:53 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
​https://bugs.webkit.org/show_bug.cgi?id=202376

Reviewed by Matt Baker.

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.get supportsScriptBlackboxing):

• UserInterface/Views/SourceCodeTreeElement.js:

(WI.SourceCodeTreeElement.prototype.updateStatus):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Resource.js (modified) (1 diff)
• UserInterface/Views/SourceCodeTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-10-07  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
+        https://bugs.webkit.org/show_bug.cgi?id=202376
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Models/Resource.js:
+        (WI.Resource.prototype.get supportsScriptBlackboxing):
+
+        * UserInterface/Views/SourceCodeTreeElement.js:
+        (WI.SourceCodeTreeElement.prototype.updateStatus):
+
 2019-10-02  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js

@@ -374 +374 @@
         if (this.isLocalResourceOverride)
             return false;
+        if (!this.finished || this.failed)
+            return false;
         return super.supportsScriptBlackboxing;
     }

trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js

@@ -169 +169 @@
             this.status = this._toggleBlackboxedImageElement;
             this._updateToggleBlackboxImageElementState();
-        }
+        } else if (this.status === this._toggleBlackboxedImageElement)
+            this.status = null;
     }