Changeset 250814 in webkit

Timestamp:

Oct 7, 2019 9:50:03 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Settings: enable the image transparency grid by default and create a checkbox for it
​https://bugs.webkit.org/show_bug.cgi?id=202678

Reviewed by Matt Baker.

• UserInterface/Base/Setting.js:

Enable the "Show transparency grid" setting by default.

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createSourcesSettingsView):
Add a checkbox for "Show transparency grid" in the "Sources" pane.

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):

• UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView):

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):

• UserInterface/Views/ResourceCollectionContentView.js:

(WI.ResourceCollectionContentView):

• Localizations/en.lproj/localizedStrings.js:

Unify the tooltip string for all of the "Show transparency grid" navigation items.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (5 diffs)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Views/CanvasContentView.js (modified) (1 diff)
• UserInterface/Views/CanvasOverviewContentView.js (modified) (1 diff)
• UserInterface/Views/ImageResourceContentView.js (modified) (1 diff)
• UserInterface/Views/RecordingContentView.js (modified) (1 diff)
• UserInterface/Views/ResourceCollectionContentView.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-10-07  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Settings: enable the image transparency grid by default and create a checkbox for it
+        https://bugs.webkit.org/show_bug.cgi?id=202678
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Base/Setting.js:
+        Enable the "Show transparency grid" setting by default.
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createSourcesSettingsView):
+        Add a checkbox for "Show transparency grid" in the "Sources" pane.
+
+        * UserInterface/Views/CanvasContentView.js:
+        (WI.CanvasContentView):
+        * UserInterface/Views/CanvasOverviewContentView.js:
+        (WI.CanvasOverviewContentView):
+        * UserInterface/Views/ImageResourceContentView.js:
+        (WI.ImageResourceContentView):
+        * UserInterface/Views/RecordingContentView.js:
+        (WI.RecordingContentView):
+        * UserInterface/Views/ResourceCollectionContentView.js:
+        (WI.ResourceCollectionContentView):
+        * Localizations/en.lproj/localizedStrings.js:
+        Unify the tooltip string for all of the "Show transparency grid" navigation items.
+
 2019-10-07  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -467 +467 @@
 localizedStrings["Entered Full-Screen Mode"] = "Entered Full-Screen Mode";
 localizedStrings["Entire Recording"] = "Entire Recording";
-localizedStrings["Entry point: "] = "Entry point: ";
 localizedStrings["Error"] = "Error";
 localizedStrings["Error: "] = "Error: ";
@@ -580 +579 @@
 localizedStrings["Hide Console (%s)"] = "Hide Console (%s)";
 localizedStrings["Hide Elements"] = "Hide Elements";
-localizedStrings["Hide Grid"] = "Hide Grid";
 localizedStrings["Hide Path"] = "Hide Path";
 localizedStrings["Hide compositing borders"] = "Hide compositing borders";
@@ -587 +585 @@
 localizedStrings["Hide the details sidebar (%s)"] = "Hide the details sidebar (%s)";
 localizedStrings["Hide the navigation sidebar (%s)"] = "Hide the navigation sidebar (%s)";
+localizedStrings["Hide transparency grid"] = "Hide transparency grid";
 localizedStrings["Hide type information"] = "Hide type information";
 localizedStrings["Hierarchy Level"] = "Hierarchy Level";
@@ -604 +603 @@
 localizedStrings["Image Size"] = "Image Size";
 localizedStrings["Images"] = "Images";
+localizedStrings["Images:"] = "Images:";
 localizedStrings["Immediate Pause Requested"] = "Immediate Pause Requested";
 localizedStrings["Import"] = "Import";
@@ -1015 +1015 @@
 localizedStrings["Show Console tab"] = "Show Console tab";
 localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Grid"] = "Show Grid";
 localizedStrings["Show Icons"] = "Show Icons";
 localizedStrings["Show Jump to Effective Property Button"] = "Show Jump to Effective Property Button";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -172 +172 @@
     showAssertionFailuresBreakpoint: new WI.Setting("show-assertion-failures-breakpoint", true),
     showCanvasPath: new WI.Setting("show-canvas-path", false),
-    showImageGrid: new WI.Setting("show-image-grid", false),
+    showImageGrid: new WI.Setting("show-image-grid", true),
     showInvisibleCharacters: new WI.Setting("show-invisible-characters", !!WI.Setting.migrateValue("show-invalid-characters")),
     showJavaScriptTypeInformation: new WI.Setting("show-javascript-type-information", false),

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js

@@ -48 +48 @@
         this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this.refreshPreview, this);
 
-        this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+        this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
         this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
         this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js

@@ -71 +71 @@
         this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._refreshPreviews, this);
 
-        this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+        this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
         this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
         this._showGridButtonNavigationItem.enabled = false;

trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js

@@ -32 +32 @@
         this._imageElement = null;
 
-        const toolTip = WI.UIString("Show Grid");
-        const activatedToolTip = WI.UIString("Hide Grid");
+        const toolTip = WI.UIString("Show transparency grid");
+        const activatedToolTip = WI.UIString("Hide transparency grid");
         this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", toolTip, activatedToolTip, "Images/NavigationItemCheckers.svg", 13, 13);
         this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js

@@ -59 +59 @@
             }
 
-            this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+            this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
             this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
             this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js

@@ -37 +37 @@
 
         if (collection.resourceType === WI.Resource.Type.Image) {
-            this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+            this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
             this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
             this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -258 +258 @@
         sourcesSettingsView.addSetting(WI.UIString("Source Maps:"), WI.settings.sourceMapsEnabled, WI.UIString("Enable source maps"));
 
+        sourcesSettingsView.addSeparator();
+
+        sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid"));
+
         this.addSettingsView(sourcesSettingsView);
     }