Changeset 250838 in webkit

Timestamp:

Oct 8, 2019 10:44:44 AM (5 years ago)

Author:

dino@apple.com

Message:

Sort Internal and Experimental features by human readable name
​https://bugs.webkit.org/show_bug.cgi?id=202667

Reviewed by Zalan Bujtas.

Sort the statically generated vectors of internal and
experimental features by their human readable name, rather than
the feature key, so that looking at them in the Settings app
doesn't make people who like alphabetical order angry.

• Scripts/GeneratePreferences.rb: Add an extra sort call to the list generation.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Scripts/GeneratePreferences.rb (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-10-08  Dean Jackson  <dino@apple.com>
+
+        Sort Internal and Experimental features by human readable name
+        https://bugs.webkit.org/show_bug.cgi?id=202667
+
+        Reviewed by Zalan Bujtas.
+
+        Sort the statically generated vectors of internal and
+        experimental features by their human readable name, rather than
+        the feature key, so that looking at them in the Settings app
+        doesn't make people who like alphabetical order angry.
+
+        * Scripts/GeneratePreferences.rb: Add an extra sort call to the list generation.
+
 2019-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/Scripts/GeneratePreferences.rb

@@ -141 +141 @@
     @preferencesNotDebug = @preferences.select { |p| !p.category }
     @preferencesDebug = @preferences.select { |p| p.category == "debug" }
-    @experimentalFeatures = @preferences.select { |p| p.category == "experimental" }
-    @internalDebugFeatures = @preferences.select { |p| p.category == "internal" }
+    @experimentalFeatures = @preferences.select { |p| p.category == "experimental" }.sort! { |x, y| x.humanReadableName <=> y.humanReadableName }
+    @internalDebugFeatures = @preferences.select { |p| p.category == "internal" }.sort! { |x, y| x.humanReadableName <=> y.humanReadableName }
 
     @preferencesBoundToSetting = @preferences.select { |p| !p.webcoreBinding }