Changeset 250847 in webkit

Timestamp:

Oct 8, 2019 11:59:37 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Do not print worker environment variables in each build step [part 3]
​https://bugs.webkit.org/show_bug.cgi?id=202698

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(RunJavaScriptCoreTests.init): Disabled logging of environment variables.
(ExtractTestResults.init): Ditto.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (6 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -845 +845 @@
     command = ['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(jsonFileName), WithProperties('--%(configuration)s')]
 
+    def __init__(self, **kwargs):
+        shell.Test.__init__(self, logEnviron=False, **kwargs)
+
     def start(self):
         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
@@ -1509 +1512 @@
         self.command = ['unzip', self.zipFile, '-d', self.resultDirectory]
 
-        super(ExtractTestResults, self).__init__(self.command)
+        master.MasterShellCommand.__init__(self, command=self.command, logEnviron=False)
 
     def resultDirectoryURL(self):

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -967 +967 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
@@ -981 +982 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},
@@ -1006 +1008 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
@@ -1020 +1023 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},
@@ -1045 +1049 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
@@ -1059 +1064 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-08  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Do not print worker environment variables in each build step [part 3]
+        https://bugs.webkit.org/show_bug.cgi?id=202698
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunJavaScriptCoreTests.__init__): Disabled logging of environment variables.
+        (ExtractTestResults.__init__): Ditto.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2019-10-08  Matt Lewis  <jlewis3@apple.com>