Changeset 250867 in webkit

Timestamp:

Oct 8, 2019 3:16:04 PM (5 years ago)

Author:

rmorisset@apple.com

Message:

dataLogIf should be ALWAYS_INLINE
​https://bugs.webkit.org/show_bug.cgi?id=202703

Reviewed by Saam Barati.

We often have the following pattern:
`
static constexpr bool verbose = false;
...
dataLogLnIf(verbose, "Something is happening");
`
To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE.

We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething() and is only known at runtime.

• wtf/DataLog.h:

(WTF::dataLogIf):
(WTF::dataLogLnIf):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/DataLog.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-10-08  Robin Morisset  <rmorisset@apple.com>
+
+        dataLogIf should be ALWAYS_INLINE
+        https://bugs.webkit.org/show_bug.cgi?id=202703
+
+        Reviewed by Saam Barati.
+
+        We often have the following pattern:
+        ```
+        static constexpr bool verbose = false;
+        ...
+        dataLogLnIf(verbose, "Something is happening");
+        ```
+        To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE.
+        
+        We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething() and is only known at runtime.
+
+        * wtf/DataLog.h:
+        (WTF::dataLogIf):
+        (WTF::dataLogLnIf):
+
 2019-10-07  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WTF/wtf/DataLog.h

@@ -53 +53 @@
 
 template<typename... Types>
-void dataLogIf(bool shouldLog, const Types&... values)
+ALWAYS_INLINE void dataLogIf(bool shouldLog, const Types&... values)
 {
-    if (shouldLog)
+    if (UNLIKELY(shouldLog))
         dataLog(values...);
 }
 
 template<typename... Types>
-void dataLogLnIf(bool shouldLog, const Types&... values)
+ALWAYS_INLINE void dataLogLnIf(bool shouldLog, const Types&... values)
 {
-    if (shouldLog)
+    if (UNLIKELY(shouldLog))
         dataLogLn(values...);
 }