Changeset 250877 in webkit

Timestamp:

Oct 8, 2019 4:38:12 PM (5 years ago)

Author:

Jonathan Bedard

Message:

REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
​https://bugs.webkit.org/show_bug.cgi?id=202419

Rubber-stamped by Aakash Jain.

• Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output): Return exit code.

• Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
For non-zero exit codes.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive.py (modified) (1 diff)
• Scripts/webkitpy/common/system/executive_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-08  Jonathan Bedard  <jbedard@apple.com>
+
+        REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
+        https://bugs.webkit.org/show_bug.cgi?id=202419
+
+        Rubber-stamped by Aakash Jain.
+
+        * Scripts/webkitpy/common/system/executive.py:
+        (Executive._run_command_with_teed_output): Return exit code.
+        * Scripts/webkitpy/common/system/executive_unittest.py:
+        (ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
+        For non-zero exit codes.
+
 2019-10-08  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/system/executive.py

@@ -129 +129 @@
                 output_line = child_process.stdout.readline()
                 teed_output.write(unicode_compatibility.decode_for(output_line, str))
+            return child_process.poll()
 
     # FIXME: Remove this deprecated method and move callers to run_command.

trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py

@@ -106 +106 @@
 
     def test_run_command_with_bad_command(self):
-        def run_bad_command():
-            Executive().run_command(["foo_bar_command_blah"], ignore_errors=True, return_exit_code=True)
-        self.assertRaises(OSError, run_bad_command)
+        self.assertRaises(OSError, lambda: Executive().run_command(["foo_bar_command_blah"], ignore_errors=True, return_exit_code=True))
+        self.assertRaises(OSError, lambda: Executive().run_and_throw_if_fail(["foo_bar_command_blah"], quiet=True))
+        self.assertRaises(ScriptError, lambda: Executive().run_command(['python', '-c', 'import sys; sys.exit(1)']))
+        self.assertRaises(ScriptError, lambda: Executive().run_and_throw_if_fail(['python', '-c', 'import sys; sys.exit(1)'], quiet=True))
 
     def test_run_command_args_type(self):