Changeset 250884 in webkit


Ignore:
Timestamp:
Oct 8, 2019 7:12:04 PM (5 years ago)
Author:
mmaxfield@apple.com
Message:

Make fast/text/complex-initial-advance.html more robust
​https://bugs.webkit.org/show_bug.cgi?id=202708
<rdar://problem/49539493>

Reviewed by Tim Horton.

We are hitting floating point precision issues. Fortunately, the part of the text that is
hitting these issues isn't actually necessary for the test.

  • fast/text/complex-initial-advance-expected.html:
  • fast/text/complex-initial-advance.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r250874 r250884  
     12019-10-08  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Make fast/text/complex-initial-advance.html more robust
     4        https://bugs.webkit.org/show_bug.cgi?id=202708
     5        <rdar://problem/49539493>
     6
     7        Reviewed by Tim Horton.
     8
     9        We are hitting floating point precision issues. Fortunately, the part of the text that is
     10        hitting these issues isn't actually necessary for the test.
     11
     12        * fast/text/complex-initial-advance-expected.html:
     13        * fast/text/complex-initial-advance.html:
     14        * platform/mac/TestExpectations:
     15
    1162019-10-08  Devin Rousso  <drousso@apple.com>
    217

  • trunk/LayoutTests/fast/text/complex-initial-advance-expected.html

    r180796 r250884  
    55</head>
    66<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
    7 <span>مليئ حياةٍ مليئ</span>
     7<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the &#x25CC;&#x064D; marks are positioned in the right place below the &#x0629; character below.</div>
     8<span>حياةٍ مليئ</span>
    89</body>
    910</html>

  • trunk/LayoutTests/fast/text/complex-initial-advance.html

    r180796 r250884  
    55</head>
    66<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
    7 <span>مليئ</span><span> </span><span>حياةٍ</span><span> </span><span>مليئ</span>
     7<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the &#x25CC;&#x064D; marks are positioned in the right place below the &#x0629; character below.</div>
     8<span>حياةٍ</span><span> </span><span>مليئ</span>
    89</body>
    910</html>

  • trunk/LayoutTests/platform/mac/TestExpectations

    r250874 r250884  
    18151815webkit.org/b/19650 [ HighSierra+ ] accessibility/mac/press-not-work-for-disabled-menu-list.html [ Pass Failure ]
    18161816
    1817 webkit.org/b/196512 [ Mojave+ ] fast/text/complex-initial-advance.html [ ImageOnlyFailure ]
    1818 
    18191817webkit.org/b/196517 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html [ Skip ]
    18201818
Note: See TracChangeset for help on using the changeset viewer.