Changeset 250915 in webkit


Ignore:
Timestamp:
Oct 9, 2019 10:24:00 AM (5 years ago)
Author:
dbates@webkit.org
Message:

Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand
​https://bugs.webkit.org/show_bug.cgi?id=202597

Reviewed by Anders Carlsson.

kVK_RightCommand has been defined in HIToolbox/Events.h since macOS Sierra. We no longer
need to maintain code to manually define it.

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyForKeyEvent):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r250914 r250915  
     12019-10-09  Daniel Bates  <dabates@apple.com>
     2
     3        Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand
     4        https://bugs.webkit.org/show_bug.cgi?id=202597
     5
     6        Reviewed by Anders Carlsson.
     7
     8        kVK_RightCommand has been defined in HIToolbox/Events.h since macOS Sierra. We no longer
     9        need to maintain code to manually define it.
     10
     11        * platform/mac/PlatformEventFactoryMac.mm:
     12        (WebCore::keyForKeyEvent):
     13
    1142019-10-09  Antti Koivisto  <antti@apple.com>
    215

  • trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm

    r242325 r250915  
    223223String keyForKeyEvent(NSEvent *event)
    224224{
    225     // This constant was missing before OS X Sierra.
    226 #ifndef kVK_RightCommand
    227 #define kVK_RightCommand 0x36
    228 #endif
    229225    switch ([event keyCode]) {
    230226    case kVK_RightCommand:
Note: See TracChangeset for help on using the changeset viewer.