Changeset 250919 in webkit

Timestamp:

Oct 9, 2019 11:40:30 AM (5 years ago)

Author:

dino@apple.com

Message:

Provide an alternate command-line flag for timeout in run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=202758
<rdar://problem/56124032>

Reviewed by Tim Horton.

I always get the flag "--time-out-ms" wrong.
Everywhere else we use the single-word version of "timeout", including
the documentation for --time-out-ms!

Add an alternate that is just "--timeout", and update the documentation
to mention it is measured in milliseconds.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-09  Dean Jackson  <dino@apple.com>
+
+        Provide an alternate command-line flag for timeout in run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=202758
+        <rdar://problem/56124032>
+
+        Reviewed by Tim Horton.
+
+        I always get the flag "--time-out-ms" wrong.
+        Everywhere else we use the single-word version of "timeout", including
+        the documentation for --time-out-ms!
+
+        Add an alternate that is just "--timeout", and update the documentation
+        to mention it is measured in milliseconds.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (parse_args):
+
 2019-10-09  youenn fablet  <youenn@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -250 +250 @@
             help="Run all tests with PASS as expected result, even those marked SKIP in the test list or " + \
                  "those which are device-specific (implies --skipped=ignore)"),
-        optparse.make_option("--time-out-ms",
-            help="Set the timeout for each test"),
+        optparse.make_option("--time-out-ms", "--timeout",
+            help="Set the timeout for each test in milliseconds"),
         optparse.make_option("--order", action="store", default="natural",
             help=("determine the order in which the test cases will be run. "