Changeset 250924 in webkit


Ignore:
Timestamp:
Oct 9, 2019 12:57:07 PM (5 years ago)
Author:
Jonathan Bedard
Message:

results.webkit.org: Increase default limit for test results
​https://bugs.webkit.org/show_bug.cgi?id=202757

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/controller/suite_controller.py:

(SuiteController): Increase DEFAULT_LIMIT.

  • resultsdbpy/resultsdbpy/controller/test_controller.py:

(TestController): Ditto.

  • resultsdbpy/resultsdbpy/view/static/js/commit.js:

(_CommitBank.prototype._load): Make commit shards larger.

  • resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
  • resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r250919 r250924  
     12019-10-09  Jonathan Bedard  <jbedard@apple.com>
     2
     3        results.webkit.org: Increase default limit for test results
     4        https://bugs.webkit.org/show_bug.cgi?id=202757
     5
     6        Rubber-stamped by Aakash Jain.
     7
     8        * resultsdbpy/resultsdbpy/controller/suite_controller.py:
     9        (SuiteController): Increase DEFAULT_LIMIT.
     10        * resultsdbpy/resultsdbpy/controller/test_controller.py:
     11        (TestController): Ditto.
     12        * resultsdbpy/resultsdbpy/view/static/js/commit.js:
     13        (_CommitBank.prototype._load): Make commit shards larger.
     14        * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
     15        * resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
     16
    1172019-10-09  Dean Jackson  <dino@apple.com>
    218

  • trunk/Tools/resultsdbpy/resultsdbpy/controller/suite_controller.py

    r247628 r250924  
    5151
    5252class SuiteController(HasCommitContext):
    53     DEFAULT_LIMIT = 100
     53    DEFAULT_LIMIT = 5000
    5454
    5555    def __init__(self, suite_context):

  • trunk/Tools/resultsdbpy/resultsdbpy/controller/test_controller.py

    r247628 r250924  
    3030
    3131class TestController(HasCommitContext):
    32     DEFAULT_LIMIT = 100
     32    DEFAULT_LIMIT = 5000
    3333
    3434    def __init__(self, test_context):

  • trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/commit.js

    r248910 r250924  
    249249            return;
    250250
    251         const limit = 250;
     251        const limit = 2500;
    252252        const query = paramsToQuery({
    253253            branch: [...this._branches],

  • trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js

    r250587 r250924  
    192192}
    193193
    194 function LimitSlider(callback, max = 10000, defaultValue = 1000) {
     194function LimitSlider(callback, max = 50000, defaultValue = 5000) {
    195195    const limitModifier = new QueryModifier('limit');
    196196    const startingValue = limitModifier.current().length ? limitModifier.current()[limitModifier.current().length -1]:defaultValue;

  • trunk/Tools/resultsdbpy/resultsdbpy/view/templates/commits.html

    r250587 r250924  
    101101var table = new Table();
    102102DOM.inject(document.getElementById('app'), `${Drawer([
    103     LimitSlider(() => {table.reload()}),
     103    LimitSlider(() => {table.reload()}, 1000, 10000),
    104104    OneLineSwitch(),
    105105    BranchSelector(() => {table.reload()}),
Note: See TracChangeset for help on using the changeset viewer.