Changeset 251154 in webkit
- Timestamp:
- Oct 15, 2019 1:45:23 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r251152 r251154 1 2019-10-15 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] 4 https://bugs.webkit.org/show_bug.cgi?id=202564 5 <rdar://problem/55974027> 6 7 Reviewed by Brent Fulgham. 8 9 Rename the SPI to a proper SPI style. 10 11 * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: 12 * UIProcess/Cocoa/UIDelegate.mm: 13 (WebKit::UIDelegate::setDelegate): 14 (WebKit::UIDelegate::UIClient::runWebAuthenticationPanel): 15 1 16 2019-10-15 youenn fablet <youenn@apple.com> 2 17 -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
r250658 r251154 138 138 - (void)_webView:(WKWebView *)webView takeFocus:(_WKFocusDirection)direction WK_API_AVAILABLE(macos(10.13.4), ios(12.2)); 139 139 140 - (void) webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));140 - (void)_webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); 141 141 142 142 #if TARGET_OS_IPHONE -
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
r250729 r251154 175 175 m_delegateMethods.webViewDidShowSafeBrowsingWarning = [delegate respondsToSelector:@selector(_webViewDidShowSafeBrowsingWarning:)]; 176 176 #if ENABLE(WEB_AUTHN) 177 m_delegateMethods.webViewRunWebAuthenticationPanelInitiatedByFrameCompletionHandler = [delegate respondsToSelector:@selector( webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:)];177 m_delegateMethods.webViewRunWebAuthenticationPanelInitiatedByFrameCompletionHandler = [delegate respondsToSelector:@selector(_webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:)]; 178 178 #endif 179 179 } … … 1295 1295 } 1296 1296 1297 auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector( webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:));1298 [(id <WKUIDelegatePrivate>)delegate webView:m_uiDelegate.m_webView runWebAuthenticationPanel:wrapper(panel) initiatedByFrame:nil completionHandler:makeBlockPtr([completionHandler = WTFMove(completionHandler), checker = WTFMove(checker)] (_WKWebAuthenticationPanelResult result) mutable {1297 auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector(_webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:)); 1298 [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView runWebAuthenticationPanel:wrapper(panel) initiatedByFrame:nil completionHandler:makeBlockPtr([completionHandler = WTFMove(completionHandler), checker = WTFMove(checker)] (_WKWebAuthenticationPanelResult result) mutable { 1299 1299 if (checker->completionHandlerHasBeenCalled()) 1300 1300 return; -
trunk/Tools/ChangeLog
r251153 r251154 1 2019-10-15 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] 4 https://bugs.webkit.org/show_bug.cgi?id=202564 5 <rdar://problem/55974027> 6 7 Reviewed by Brent Fulgham. 8 9 * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: 10 (-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): 11 (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): Deleted. 12 1 13 2019-10-15 Aakash Jain <aakash_jain@apple.com> 2 14 -
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm
r251148 r251154 80 80 } 81 81 82 - (void) webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler82 - (void)_webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler 83 83 { 84 84 webAuthenticationPanelRan = true;
Note: See TracChangeset
for help on using the changeset viewer.