Changeset 251267 in webkit

Timestamp:

Oct 17, 2019 4:42:09 PM (5 years ago)

Author:

Chris Dumez

Message:

Unreviewed, rolling out r251255.

This is causing the existing back/forward tests to be flaky

Reverted changeset:

"Don't put pages that have not reached the non-visually empty
layout milestone in the back/forward cache"
​https://bugs.webkit.org/show_bug.cgi?id=203108
​https://trac.webkit.org/changeset/251255

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• history/BackForwardCache.cpp (modified) (1 diff)
• page/DiagnosticLoggingKeys.cpp (modified) (1 diff)
• page/DiagnosticLoggingKeys.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-17  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, rolling out r251255.
+
+        This is causing the existing back/forward tests to be flaky
+
+        Reverted changeset:
+
+        "Don't put pages that have not reached the non-visually empty
+        layout milestone in the back/forward cache"
+        https://bugs.webkit.org/show_bug.cgi?id=203108
+        https://trac.webkit.org/changeset/251255
+
 2019-10-17  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/history/BackForwardCache.cpp

@@ -133 +133 @@
         isCacheable = false;
     }
-    if (frame.isMainFrame() && frame.view() && !frame.view()->isVisuallyNonEmpty()) {
-        PCLOG("   -Main frame is visually empty");
-        logBackForwardCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::visuallyEmptyKey());
-        isCacheable = false;
-    }
     if (frameLoader.quickRedirectComing()) {
         PCLOG("   -Quick redirect is coming");

trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp

@@ -219 +219 @@
 }
 
-String DiagnosticLoggingKeys::visuallyEmptyKey()
-{
-    return "visuallyEmpty"_s;
-}
-
 String DiagnosticLoggingKeys::noDocumentLoaderKey()
 {

trunk/Source/WebCore/page/DiagnosticLoggingKeys.h

@@ -117 +117 @@
     static String backForwardCacheKey();
     static String backForwardCacheFailureKey();
-    static String visuallyEmptyKey();
     static String pageContainsAtLeastOneMediaEngineKey();
     static String pageContainsAtLeastOnePluginKey();