Changeset 251275 in webkit
- Timestamp:
- Oct 17, 2019 10:01:50 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r251273 r251275 1 2019-10-17 Chris Dumez <cdumez@apple.com> 2 3 Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache 4 https://bugs.webkit.org/show_bug.cgi?id=203108 5 <rdar://problem/56375671> 6 7 Reviewed by Geoff Garen. 8 9 * http/tests/navigation/page-cache-pending-load.html: 10 Tweak test to add the stylesheet to the body instead of the head since a document 11 with a pending stylesheet before the body qualifies as visually empty. The test 12 would be flaky otherwise. 13 1 14 2019-10-17 Simon Fraser <simon.fraser@apple.com> 2 15 -
trunk/LayoutTests/http/tests/navigation/page-cache-pending-load.html
r251220 r251275 34 34 link.type = "text/css"; 35 35 link.href = "/incremental/resources/slow-utf8-css.pl"; 36 document. head.appendChild(link);36 document.body.appendChild(link); 37 37 38 38 var script = document.createElement("script"); -
trunk/Source/WebCore/ChangeLog
r251273 r251275 1 2019-10-17 Chris Dumez <cdumez@apple.com> 2 3 Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache 4 https://bugs.webkit.org/show_bug.cgi?id=203108 5 <rdar://problem/56375671> 6 7 Reviewed by Geoff Garen. 8 9 We don't want to go back to a visually empty page on back/forward navigation. 10 11 * history/BackForwardCache.cpp: 12 (WebCore::canCacheFrame): 13 * page/DiagnosticLoggingKeys.cpp: 14 (WebCore::DiagnosticLoggingKeys::visuallyEmptyKey): 15 * page/DiagnosticLoggingKeys.h: 16 1 17 2019-10-17 Simon Fraser <simon.fraser@apple.com> 2 18 -
trunk/Source/WebCore/history/BackForwardCache.cpp
r251267 r251275 133 133 isCacheable = false; 134 134 } 135 if (frame.isMainFrame() && frame.view() && !frame.view()->isVisuallyNonEmpty()) { 136 PCLOG(" -Main frame is visually empty"); 137 logBackForwardCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::visuallyEmptyKey()); 138 isCacheable = false; 139 } 135 140 if (frameLoader.quickRedirectComing()) { 136 141 PCLOG(" -Quick redirect is coming"); -
trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp
r251267 r251275 219 219 } 220 220 221 String DiagnosticLoggingKeys::visuallyEmptyKey() 222 { 223 return "visuallyEmpty"_s; 224 } 225 221 226 String DiagnosticLoggingKeys::noDocumentLoaderKey() 222 227 { -
trunk/Source/WebCore/page/DiagnosticLoggingKeys.h
r251267 r251275 117 117 static String backForwardCacheKey(); 118 118 static String backForwardCacheFailureKey(); 119 static String visuallyEmptyKey(); 119 120 static String pageContainsAtLeastOneMediaEngineKey(); 120 121 static String pageContainsAtLeastOnePluginKey();
Note: See TracChangeset
for help on using the changeset viewer.