Changeset 251294 in webkit

Timestamp:

Oct 18, 2019 12:44:22 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Flaky Test: fast/events/resize-subframe-in-rendering-update.html
​https://bugs.webkit.org/show_bug.cgi?id=203140

Reviewed by Simon Fraser.

The flakiness was caused by the race condition between rAF and setTimeout. In many cases,
setTimeout was getting scheduled after the next rAF and prevented some assertions to run in time.

Fixed the flakiness by moving setTimeout to outside the setTimeout in which tests run so that
those assertions would always run.

Rebaselined the test since these assertions in setTimeout are now always included in the results.

• fast/events/resize-subframe-in-rendering-update-expected.txt:
• fast/events/resize-subframe-in-rendering-update.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/resize-subframe-in-rendering-update-expected.txt (modified) (1 diff)
• fast/events/resize-subframe-in-rendering-update.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Flaky Test: fast/events/resize-subframe-in-rendering-update.html
+        https://bugs.webkit.org/show_bug.cgi?id=203140
+
+        Reviewed by Simon Fraser.
+
+        The flakiness was caused by the race condition between rAF and setTimeout. In many cases,
+        setTimeout was getting scheduled after the next rAF and prevented some assertions to run in time.
+
+        Fixed the flakiness by moving setTimeout to outside the setTimeout in which tests run so that
+        those assertions would always run.
+
+        Rebaselined the test since these assertions in setTimeout are now always included in the results.
+
+        * fast/events/resize-subframe-in-rendering-update-expected.txt:
+        * fast/events/resize-subframe-in-rendering-update.html:
+
 2019-10-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update-expected.txt

@@ -8 +8 @@
 iframeAA.style.width = "200px"; updateLayout(iframeAA)
 PASS logs.length is 0
+After 0s setTimeout
+PASS logs.length is 0
 After requestAnimationFrame
 PASS logs.length is 3

trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update.html

@@ -38 +38 @@
         evalAndLog('iframeAA.style.width = "200px"; updateLayout(iframeAA)');
         shouldBe('logs.length', '0');
-        setTimeout(() => {
-            debug('After 0s setTimeout');
-            shouldBe('logs.length', '0');
-        }, 0);
         requestAnimationFrame(() => {
             debug('After requestAnimationFrame');
@@ -51 +47 @@
         });
     }, 0);
+    setTimeout(() => {
+        debug('After 0s setTimeout');
+        shouldBe('logs.length', '0');
+    }, 0);
 });