Changeset 251376 in webkit

Timestamp:

Oct 21, 2019 1:09:25 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: replace all uses of window.*Agent with a target-specific call
​https://bugs.webkit.org/show_bug.cgi?id=201149

Reviewed by Matt Baker.

Most of these were changed in r251227, but a few appear to have slipped through the cracks.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.debuggerDidResume):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
(WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DebuggerManager.js (modified) (1 diff)
• UserInterface/Views/SourceCodeTextEditor.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-10-21  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: replace all uses of `window.*Agent` with a target-specific call
+        https://bugs.webkit.org/show_bug.cgi?id=201149
+
+        Reviewed by Matt Baker.
+
+        Most of these were changed in r251227, but a few appear to have slipped through the cracks.
+
+        * UserInterface/Controllers/DebuggerManager.js:
+        (WI.DebuggerManager.prototype.debuggerDidResume):
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        (WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
+        (WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
+
 2019-10-18  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js

@@ -829 +829 @@
         // This delay ensures the user interface does not flash between brief steps
         // or successive breakpoints.
-        if (!target.DebuggerAgent.setPauseOnAssertions) {
+        if (!target.hasCommand("Debugger.setPauseOnAssertions")) {
             this._delayedResumeTimeout = setTimeout(this._didResumeInternal.bind(this, target), 50);
             return;

trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js

@@ -2173 +2173 @@
     {
         // COMPATIBILITY (iOS 8): Runtime.getRuntimeTypesForVariablesAtOffsets did not exist yet.
-        if (!this.target.RuntimeAgent.getRuntimeTypesForVariablesAtOffsets)
+        if (!this.target.hasCommand("Runtime.getRuntimeTypesForVariablesAtOffsets"))
             return;
 
@@ -2186 +2186 @@
     {
         // COMPATIBILITY (iOS 8): Runtime.getBasicBlocks did not exist yet.
-        if (!this.target.RuntimeAgent.getBasicBlocks)
+        if (!this.target.hasCommand("Runtime.getBasicBlocks"))
             return;