Changeset 251387 in webkit

Timestamp:

Oct 21, 2019 3:07:03 PM (5 years ago)

Author:

Wenson Hsieh

Message:

editing/selection/ios/selection-handles-in-readonly-input.html times out
​https://bugs.webkit.org/show_bug.cgi?id=203203
<rdar://problem/47710799>

Reviewed by Tim Horton.

This test began to fail in iOS 13, since we (intentionally) no longer show a keyboard when focusing readonly
inputs. The test is intended to verify that moving selection handles inside a readonly input field will not
cause the selection to disappear, but it currently waits forever for the keyboard to appear after initially
tapping a readonly input field.

We can fix this test by instead using a tap-and-half gesture to select the text ('aa').

• editing/selection/ios/selection-handles-in-readonly-input.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• editing/selection/ios/selection-handles-in-readonly-input.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        editing/selection/ios/selection-handles-in-readonly-input.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=203203
+        <rdar://problem/47710799>
+
+        Reviewed by Tim Horton.
+
+        This test began to fail in iOS 13, since we (intentionally) no longer show a keyboard when focusing `readonly`
+        inputs. The test is intended to verify that moving selection handles inside a readonly input field will not
+        cause the selection to disappear, but it currently waits forever for the keyboard to appear after initially
+        tapping a readonly input field.
+
+        We can fix this test by instead using a tap-and-half gesture to select the text ('aa').
+
+        * editing/selection/ios/selection-handles-in-readonly-input.html:
+
 2019-10-21  Daniel Bates  <dabates@apple.com>
 

trunk/LayoutTests/editing/selection/ios/selection-handles-in-readonly-input.html

@@ -40 +40 @@
 
 async function runTest() {
-    await UIHelper.activateAndWaitForInputSessionAt(100, 50);
-    input.setSelectionRange(0, 2);
+    // First, focus the readonly input.
+    await UIHelper.activateAt(100, 50);
+    await UIHelper.waitForDoubleTapDelay();
+
+    // Then, select 'aa' with a tap-and-half gesture.
+    await UIHelper.activateAt(100, 50);
+    await longPressAtPoint(100, 50);
+
     let grabberEndRect = null;
     while (!grabberEndRect || !grabberEndRect.width || !grabberEndRect.height)