Changeset 251401 in webkit

Timestamp:

Oct 21, 2019 5:22:09 PM (5 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Add ability to display time on bubbles
​https://bugs.webkit.org/show_bug.cgi?id=203202
<rdar://problem/56436621>

Rubber-stamped by Aakash Jain.

• resultsdbpy/resultsdbpy/view/static/js/timeline.js: Add switch to show times under each bubble.
• resultsdbpy/resultsdbpy/view/templates/search.html: Correctly update timeline on callback.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/timeline.js (modified) (5 diffs)
• resultsdbpy/resultsdbpy/view/templates/search.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-21  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Add ability to display time on bubbles
+        https://bugs.webkit.org/show_bug.cgi?id=203202
+        <rdar://problem/56436621>
+
+        Rubber-stamped by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Add switch to show times under each bubble.
+        * resultsdbpy/resultsdbpy/view/templates/search.html: Correctly update timeline on callback.
+
 2019-10-21  Dean Jackson  <dino@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

@@ -35 +35 @@
 
 let willFilterExpected = false;
+let showTestTimes = false;
 
 function minimumUuidForResults(results, limit) {
@@ -254 +255 @@
             }
 
+            // Some special combination logic
+            if (key === 'time') {
+                out[key] = Math.max(
+                    out[key] ? out[key] : 0,
+                    obj[key] ? obj[key] : 0,
+                );
+                return;
+            }
+
             // If the key exists, but doesn't match, delete it
             if (!(key in obj) || out[key] !== obj[key]) {
@@ -535 +545 @@
                     });
                 }
+                const time = data.time ? Math.round(data.time / 1000) : 0;
+                if (time && showTestTimes)
+                    tag = time;
 
                 return drawDot(context, x, y, false, tag ? tag : null, symbol, false, color);
@@ -859 +872 @@
 
     if (callback) {
-        const swtch = REF.createRef({
+        const filterSwitch = REF.createRef({
             onElementMount: (element) => {
                 element.onchange = () => {
@@ -873 +886 @@
             },
         });
+        const showTimesSwitch = REF.createRef({
+            onElementMount: (element) => {
+                element.onchange = () => {
+                    if (element.checked)
+                        showTestTimes = true;
+                    else
+                        showTestTimes = false;
+                    callback();
+                };
+            },
+        });
 
         result += `<div class="input">
             <label>Filter expected results</label>
             <label class="switch">
-                <input type="checkbox"${willFilterExpected ? ' checked': ''} ref="${swtch}">
+                <input type="checkbox"${willFilterExpected ? ' checked': ''} ref="${filterSwitch}">
                 <span class="slider"></span>
             </label>
-        </div>`;
+        </div>`
+        if (!plural)
+            result += `<div class="input">
+                <label>Show test times</label>
+                <label class="switch">
+                    <input type="checkbox"${showTestTimes ? ' checked': ''} ref="${showTimesSwitch}">
+                    <span class="slider"></span>
+                </label>
+            </div>`;
     }
 

trunk/Tools/resultsdbpy/resultsdbpy/view/templates/search.html

@@ -230 +230 @@
     ${Drawer([
         Legend(() => {
-            view.children.forEach((child) => {
+            view.ref.state.children.forEach((child) => {
                 child.timeline.update();
             });