Changeset 251482 in webkit
- Timestamp:
- Oct 23, 2019 11:29:29 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r251474 r251482 1 2019-10-23 Sihui Liu <sihui_liu@apple.com> 2 3 [ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing 4 https://bugs.webkit.org/show_bug.cgi?id=203173 5 <rdar://problem/56424721> 6 7 Reviewed by Geoffrey Garen. 8 9 play() returns a promise and the promise can be rejected by a later pause(). We didn't handle 10 that case so we could receive a type JavaScript message for the unhandled rejected promise. 11 12 * inspector/console/webcore-logging.html: 13 * platform/mac-wk1/TestExpectations: 14 1 15 2019-10-22 Simon Fraser <simon.fraser@apple.com> 2 16 -
trunk/LayoutTests/inspector/console/webcore-logging.html
r243328 r251482 18 18 { 19 19 video.currentTime = 0; 20 video.play() ;20 video.play().catch((err) => { }); 21 21 TestPage.dispatchEventToFrontend('PlayEvent', {count: 1}); 22 22 } -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r251481 r251482 802 802 http/tests/is-logged-in/ [ Skip ] 803 803 804 webkit.org/b/203173 inspector/console/webcore-logging.html [ Pass Failure ]805 806 804 webkit.org/b/203176 [ Debug ] fast/scrolling/latching/scroll-select-bottom-test.html [ Pass Failure ] 807 805 -
trunk/Source/JavaScriptCore/ChangeLog
r251475 r251482 1 2019-10-23 Sihui Liu <sihui_liu@apple.com> 2 3 [ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing 4 https://bugs.webkit.org/show_bug.cgi?id=203173 5 <rdar://problem/56424721> 6 7 Hold a strong reference to JSGlobalOjbect in ConsoleMessage so that object is not garbage collected before 8 WebConsoleAgent::frameWindowDiscarded. 9 10 Covered by existing test: inspector/console/webcore-logging.html. 11 12 Reviewed by Geoffrey Garen. 13 14 * inspector/ConsoleMessage.cpp: 15 (Inspector::ConsoleMessage::ConsoleMessage): 16 (Inspector::ConsoleMessage::clear): 17 * inspector/ConsoleMessage.h: 18 1 19 2019-10-22 Yusuke Suzuki <ysuzuki@apple.com> 2 20 -
trunk/Source/JavaScriptCore/inspector/ConsoleMessage.cpp
r251425 r251482 118 118 , m_level(level) 119 119 , m_url() 120 , m_globalObject(globalObject) 121 , m_requestId(IdentifiersFactory::requestId(requestIdentifier)) 122 { 120 , m_requestId(IdentifiersFactory::requestId(requestIdentifier)) 121 { 122 if (globalObject) 123 m_globalObject = { globalObject->vm(), globalObject }; 124 123 125 if (!messages.size()) 124 126 return; … … 341 343 if (m_arguments) 342 344 m_arguments = nullptr; 345 346 if (m_globalObject) 347 m_globalObject.clear(); 343 348 } 344 349 … … 349 354 350 355 if (m_globalObject) 351 return m_globalObject ;356 return m_globalObject.get(); 352 357 353 358 return nullptr; -
trunk/Source/JavaScriptCore/inspector/ConsoleMessage.h
r251425 r251482 32 32 33 33 #include "ConsoleTypes.h" 34 #include "Strong.h" 34 35 #include <wtf/FastMalloc.h> 35 36 #include <wtf/Forward.h> … … 95 96 Vector<JSONLogValue> m_jsonLogValues; 96 97 String m_url; 97 JSC:: JSGlobalObject* m_globalObject { nullptr };98 JSC::Strong<JSC::JSGlobalObject> m_globalObject; 98 99 unsigned m_line { 0 }; 99 100 unsigned m_column { 0 };
Note: See TracChangeset
for help on using the changeset viewer.