Changeset 251499 in webkit
- Timestamp:
- Oct 23, 2019 2:22:40 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 14 deleted
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r251495 r251499 1 2019-10-23 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 [SVG2] Fix SVGElement to conform with SVG2 4 https://bugs.webkit.org/show_bug.cgi?id=203280 5 6 Reviewed by Simon Fraser. 7 8 * platform/gtk/svg/custom/getPresentationAttribute-expected.png: Removed. 9 * platform/gtk/svg/custom/getPresentationAttribute-expected.txt: Removed. 10 * platform/ios/svg/custom/getPresentationAttribute-expected.txt: Removed. 11 * platform/mac/svg/custom/getPresentationAttribute-expected.png: Removed. 12 * platform/mac/svg/custom/getPresentationAttribute-expected.txt: Removed. 13 * platform/mac/svg/custom/getPresentationAttribute-modify-expected.png: Removed. 14 * platform/win/svg/custom/getPresentationAttribute-expected.txt: Removed. 15 * platform/wincairo/svg/custom/getPresentationAttribute-expected.txt: Removed. 16 * platform/wpe/svg/custom/getPresentationAttribute-expected.txt: Removed. 17 * svg/custom/getPresentationAttribute.svg: Removed. 18 * svg/custom/path-getPresentationAttribute-crash-expected.txt: Removed. 19 * svg/custom/path-getPresentationAttribute-crash.html: Removed. 20 SVGElement.getPresentationAttribute has to be removed. 21 1 22 2019-10-23 Chris Dumez <cdumez@apple.com> 2 23 -
trunk/LayoutTests/imported/w3c/ChangeLog
r251492 r251499 1 2019-10-23 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 [SVG2] Fix SVGElement to conform with SVG2 4 https://bugs.webkit.org/show_bug.cgi?id=203280 5 6 Reviewed by Simon Fraser. 7 8 * web-platform-tests/svg/historical-expected.txt: 9 Some sub-tests are now passing with this change. 10 1 11 2019-10-23 Rob Buis <rbuis@igalia.com> 2 12 -
trunk/LayoutTests/imported/w3c/web-platform-tests/svg/historical-expected.txt
r251461 r251499 22 22 PASS SVGURIReference mixin interface must not be exposed 23 23 PASS SVGZoomAndPan mixin interface must not be exposed 24 FAIL SVGElement.prototype.getPresentationAttribute must be removed assert_false: expected false got true 24 PASS SVGElement.prototype.getPresentationAttribute must be removed 25 25 PASS SVGElement.prototype.xmlbase must be removed 26 FAIL SVGElement.prototype.xmllang must be removed assert_false: expected false got true 27 FAIL SVGElement.prototype.xmlspace must be removed assert_false: expected false got true 26 PASS SVGElement.prototype.xmllang must be removed 27 PASS SVGElement.prototype.xmlspace must be removed 28 28 FAIL SVGGraphicsElement.prototype.getTransformToElement must be removed assert_false: expected false got true 29 29 FAIL SVGGraphicsElement.prototype.hasExtension must be removed assert_false: expected false got true -
trunk/Source/WebCore/ChangeLog
r251498 r251499 1 2019-10-23 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 [SVG2] Fix SVGElement to conform with SVG2 4 https://bugs.webkit.org/show_bug.cgi?id=203280 5 6 Reviewed by Simon Fraser. 7 8 The interface of SVGElement is defined here: 9 https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement. 10 11 -- Remove SVGElement.getPresentationAttribute. 12 -- Remove the SVGElement attributes xmllang and xmlspace. 13 -- Remove the class SVGLangSpace 14 15 * Sources.txt: 16 * WebCore.xcodeproj/project.pbxproj: 17 * svg/SVGComponentTransferFunctionElement.cpp: 18 (WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged): 19 Fix a bug. This function was calling SVGLangSpace::isKnownAttribute() 20 instead of calling PropertyRegistry::isKnownAttribute(). 21 22 * svg/SVGElement.cpp: 23 (WebCore::SVGElement::SVGElement): 24 (WebCore::SVGElement::parseAttribute): 25 (WebCore::SVGElement::svgAttributeChanged): 26 (WebCore::SVGElement::getPresentationAttribute): Deleted. 27 * svg/SVGElement.h: 28 * svg/SVGElement.idl: 29 * svg/SVGFilterPrimitiveStandardAttributes.cpp: 30 (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged): 31 Fix a bug. This function was calling SVGLangSpace::isKnownAttribute() 32 instead of calling PropertyRegistry::isKnownAttribute(). 33 34 * svg/SVGLangSpace.cpp: Removed. 35 * svg/SVGLangSpace.h: Removed. 36 * svg/SVGUseElement.cpp: 37 (WebCore::SVGUseElement::svgAttributeChanged): 38 1 39 2019-10-22 Jiewen Tan <jiewen_tan@apple.com> 2 40 -
trunk/Source/WebCore/Sources.txt
r251318 r251499 2415 2415 svg/SVGImageElement.cpp 2416 2416 svg/SVGImageLoader.cpp 2417 svg/SVGLangSpace.cpp2418 2417 svg/SVGLengthContext.cpp 2419 2418 svg/SVGLengthValue.cpp -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r251488 r251499 3452 3452 B2227A2A0D00BF220071B782 /* SVGGradientElement.h in Headers */ = {isa = PBXBuildFile; fileRef = B22278940D00BF200071B782 /* SVGGradientElement.h */; }; 3453 3453 B2227A2D0D00BF220071B782 /* SVGImageElement.h in Headers */ = {isa = PBXBuildFile; fileRef = B22278970D00BF200071B782 /* SVGImageElement.h */; }; 3454 B2227A300D00BF220071B782 /* SVGLangSpace.h in Headers */ = {isa = PBXBuildFile; fileRef = B222789A0D00BF200071B782 /* SVGLangSpace.h */; };3455 3454 B2227A360D00BF220071B782 /* SVGLengthList.h in Headers */ = {isa = PBXBuildFile; fileRef = B22278A00D00BF200071B782 /* SVGLengthList.h */; settings = {ATTRIBUTES = (Private, ); }; }; 3456 3455 B2227A390D00BF220071B782 /* SVGLinearGradientElement.h in Headers */ = {isa = PBXBuildFile; fileRef = B22278A30D00BF200071B782 /* SVGLinearGradientElement.h */; }; … … 12341 12340 B22278970D00BF200071B782 /* SVGImageElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGImageElement.h; sourceTree = "<group>"; }; 12342 12341 B22278980D00BF200071B782 /* SVGImageElement.idl */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = text; path = SVGImageElement.idl; sourceTree = "<group>"; }; 12343 B22278990D00BF200071B782 /* SVGLangSpace.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = SVGLangSpace.cpp; sourceTree = "<group>"; };12344 B222789A0D00BF200071B782 /* SVGLangSpace.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGLangSpace.h; sourceTree = "<group>"; };12345 12342 B222789E0D00BF200071B782 /* SVGLength.idl */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = text; path = SVGLength.idl; sourceTree = "<group>"; }; 12346 12343 B22278A00D00BF200071B782 /* SVGLengthList.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGLengthList.h; sourceTree = "<group>"; }; … … 24377 24374 B28C6A200D00C44800334AA4 /* SVGImageLoader.cpp */, 24378 24375 B28C6A210D00C44800334AA4 /* SVGImageLoader.h */, 24379 B22278990D00BF200071B782 /* SVGLangSpace.cpp */,24380 B222789A0D00BF200071B782 /* SVGLangSpace.h */,24381 24376 7CE58D511DD7B09300128552 /* SVGLength.h */, 24382 24377 B222789E0D00BF200071B782 /* SVGLength.idl */, … … 32192 32187 0854B01F1255E4E600B9CDD0 /* SVGInlineFlowBox.h in Headers */, 32193 32188 0854B0211255E4E600B9CDD0 /* SVGInlineTextBox.h in Headers */, 32194 B2227A300D00BF220071B782 /* SVGLangSpace.h in Headers */,32195 32189 7134496E146941B300720312 /* SVGLengthContext.h in Headers */, 32196 32190 B2227A360D00BF220071B782 /* SVGLengthList.h in Headers */, -
trunk/Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp
r246490 r251499 91 91 void SVGComponentTransferFunctionElement::svgAttributeChanged(const QualifiedName& attrName) 92 92 { 93 if ( isKnownAttribute(attrName)) {93 if (PropertyRegistry::isKnownAttribute(attrName)) { 94 94 InstanceInvalidationGuard guard(*this); 95 95 invalidateFilterPrimitiveParent(this); -
trunk/Source/WebCore/svg/SVGElement.cpp
r251290 r251499 161 161 SVGElement::SVGElement(const QualifiedName& tagName, Document& document) 162 162 : StyledElement(tagName, document, CreateSVGElement) 163 , SVGLangSpace(this)164 163 , m_propertyAnimatorFactory(makeUnique<SVGPropertyAnimatorFactory>()) 165 164 { … … 355 354 return; 356 355 } 357 358 SVGLangSpace::parseAttribute(name, value);359 356 } 360 357 … … 835 832 return; 836 833 } 837 838 SVGLangSpace::svgAttributeChanged(attrName);839 834 } 840 835 … … 879 874 } 880 875 881 RefPtr<DeprecatedCSSOMValue> SVGElement::getPresentationAttribute(const String& name)882 {883 if (!hasAttributesWithoutUpdate())884 return 0;885 886 QualifiedName attributeName(nullAtom(), name, nullAtom());887 const Attribute* attribute = findAttributeByName(attributeName);888 if (!attribute)889 return 0;890 891 auto style = MutableStyleProperties::create(SVGAttributeMode);892 CSSPropertyID propertyID = cssPropertyIdForSVGAttributeName(attribute->name());893 style->setProperty(propertyID, attribute->value());894 auto cssValue = style->getPropertyCSSValue(propertyID);895 if (!cssValue)896 return nullptr;897 return cssValue->createDeprecatedCSSOMWrapper(style->ensureCSSStyleDeclaration());898 }899 900 876 bool SVGElement::instanceUpdatesBlocked() const 901 877 { -
trunk/Source/WebCore/svg/SVGElement.h
r251290 r251499 24 24 25 25 #include "SVGAnimatedPropertyImpl.h" 26 #include "SVGLangSpace.h"27 26 #include "SVGLocatable.h" 28 27 #include "SVGNames.h" … … 48 47 void mapAttributeToCSSProperty(HashMap<AtomStringImpl*, CSSPropertyID>* propertyNameToIdMap, const QualifiedName& attrName); 49 48 50 class SVGElement : public StyledElement, public SVG LangSpace, public SVGPropertyOwner {49 class SVGElement : public StyledElement, public SVGPropertyOwner { 51 50 WTF_MAKE_ISO_ALLOCATED(SVGElement); 52 51 public: … … 57 56 58 57 String title() const override; 59 RefPtr<DeprecatedCSSOMValue> getPresentationAttribute(const String& name);60 58 virtual bool supportsMarkers() const { return false; } 61 59 bool hasRelativeLengths() const { return !m_elementsWithRelativeLengths.isEmpty(); } -
trunk/Source/WebCore/svg/SVGElement.idl
r249212 r251499 24 24 JSGenerateToNativeObject, 25 25 ] interface SVGElement : Element { 26 readonly attribute SVGSVGElement ownerSVGElement;27 readonly attribute SVGElement viewportElement;28 29 attribute DOMString xmllang;30 attribute DOMString xmlspace;31 26 32 27 readonly attribute SVGAnimatedString className; 33 28 34 // FIXME: Using "undefined" as default parameter value is wrong. 35 // This method is deprecated, and we'd like to remove it someday. 36 DeprecatedCSSOMValue getPresentationAttribute(optional DOMString name = "undefined"); 29 readonly attribute SVGSVGElement? ownerSVGElement; 30 readonly attribute SVGElement? viewportElement; 37 31 }; 38 32 -
trunk/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp
r249822 r251499 76 76 void SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(const QualifiedName& attrName) 77 77 { 78 if ( isKnownAttribute(attrName)) {78 if (PropertyRegistry::isKnownAttribute(attrName)) { 79 79 InstanceInvalidationGuard guard(*this); 80 80 invalidate(); -
trunk/Source/WebCore/svg/SVGUseElement.cpp
r251318 r251499 175 175 } 176 176 177 if (SVGLangSpace::isKnownAttribute(attrName))178 invalidateShadowTree();179 180 177 SVGGraphicsElement::svgAttributeChanged(attrName); 181 178 }
Note: See TracChangeset
for help on using the changeset viewer.