Changeset 251504 in webkit


Ignore:
Timestamp:
Oct 23, 2019 3:39:34 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[macOS WK2] Layout Test http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html is a flaky timeout (198670)
https://bugs.webkit.org/show_bug.cgi?id=198670
<rdar://problem/51529251>

Patch by Kate Cheney <Kate Cheney> on 2019-10-23
Reviewed by John Wilander.

Was able to reproduce flaky timeouts extremely rarely accompanied by
the error 'JS ERROR TypeError: null is not an object (evaluating
'document.body.appendChild’)'. Since the frame was being created in
head, the document body was sometimes not finished loading by the time
the appendChild call was being made. Moving the frame load to the body should fix this flakiness.

  • http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html:
  • platform/mac-wk2/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r251501 r251504  
     12019-10-23  Kate Cheney  <katherine_cheney@apple.com>
     2
     3        [macOS WK2] Layout Test http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html is a flaky timeout (198670)
     4        https://bugs.webkit.org/show_bug.cgi?id=198670
     5        <rdar://problem/51529251>
     6
     7        Reviewed by John Wilander.
     8
     9        Was able to reproduce flaky timeouts extremely rarely accompanied by
     10        the error 'JS ERROR TypeError: null is not an object (evaluating
     11        'document.body.appendChild’)'. Since the frame was being created in
     12        head, the document body was sometimes not finished loading by the time
     13        the appendChild call was being made. Moving the frame load to the body should fix this flakiness.
     14
     15        * http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html:
     16        * platform/mac-wk2/TestExpectations:
     17
    1182019-10-23  Kate Cheney  <katherine_cheney@apple.com>
    219
  • trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html

    r235569 r251504  
    22<html>
    33<head>
     4</head>
     5<body>
    46    <script src="/js-test-resources/js-test.js"></script>
    57    <script src="/js-test-resources/ui-helper.js"></script>
     
    8587        }
    8688    </script>
    87 </head>
    88 <body>
    8989</body>
    9090</html>
  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r251441 r251504  
    688688http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html [ Pass ]
    689689[ HighSierra+ ] http/tests/storageAccess/ [ Pass ]
    690 webkit.org/b/198670 [ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Pass Timeout ]
    691690[ HighSierra+ ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html [ Pass Timeout ]
    692691[ HighSierra+ ] http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture.html [ Skip ]
Note: See TracChangeset for help on using the changeset viewer.