Changeset 251513 in webkit
- Timestamp:
- Oct 23, 2019 5:04:57 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r251509 r251513 1 2019-10-23 Truitt Savell <tsavell@apple.com> 2 3 Unreviewed, rolling out r251482. 4 5 r251261 broke multiple tests, reverting this as part of that 6 rollout. 7 8 Reverted changeset: 9 10 "[ Mac WK1 ] REGRESSION (r251261): Layout Test 11 inspector/console/webcore-logging.html is consistently 12 Failing" 13 https://bugs.webkit.org/show_bug.cgi?id=203173 14 https://trac.webkit.org/changeset/251482 15 1 16 2019-10-23 Chris Dumez <cdumez@apple.com> 2 17 -
trunk/LayoutTests/inspector/console/webcore-logging.html
r251482 r251513 18 18 { 19 19 video.currentTime = 0; 20 video.play() .catch((err) => { });20 video.play(); 21 21 TestPage.dispatchEventToFrontend('PlayEvent', {count: 1}); 22 22 } -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r251482 r251513 802 802 http/tests/is-logged-in/ [ Skip ] 803 803 804 webkit.org/b/203173 inspector/console/webcore-logging.html [ Pass Failure ] 805 804 806 webkit.org/b/203176 [ Debug ] fast/scrolling/latching/scroll-select-bottom-test.html [ Pass Failure ] 805 807 -
trunk/Source/JavaScriptCore/ChangeLog
r251494 r251513 1 2019-10-23 Truitt Savell <tsavell@apple.com> 2 3 Unreviewed, rolling out r251482. 4 5 r251261 broke multiple tests, reverting this as part of that 6 rollout. 7 8 Reverted changeset: 9 10 "[ Mac WK1 ] REGRESSION (r251261): Layout Test 11 inspector/console/webcore-logging.html is consistently 12 Failing" 13 https://bugs.webkit.org/show_bug.cgi?id=203173 14 https://trac.webkit.org/changeset/251482 15 1 16 2019-10-23 Yury Semikhatsky <yurys@chromium.org> 2 17 -
trunk/Source/JavaScriptCore/inspector/ConsoleMessage.cpp
r251482 r251513 118 118 , m_level(level) 119 119 , m_url() 120 , m_requestId(IdentifiersFactory::requestId(requestIdentifier)) 121 { 122 if (globalObject) 123 m_globalObject = { globalObject->vm(), globalObject }; 124 120 , m_globalObject(globalObject) 121 , m_requestId(IdentifiersFactory::requestId(requestIdentifier)) 122 { 125 123 if (!messages.size()) 126 124 return; … … 343 341 if (m_arguments) 344 342 m_arguments = nullptr; 345 346 if (m_globalObject)347 m_globalObject.clear();348 343 } 349 344 … … 354 349 355 350 if (m_globalObject) 356 return m_globalObject .get();351 return m_globalObject; 357 352 358 353 return nullptr; -
trunk/Source/JavaScriptCore/inspector/ConsoleMessage.h
r251482 r251513 32 32 33 33 #include "ConsoleTypes.h" 34 #include "Strong.h"35 34 #include <wtf/FastMalloc.h> 36 35 #include <wtf/Forward.h> … … 96 95 Vector<JSONLogValue> m_jsonLogValues; 97 96 String m_url; 98 JSC:: Strong<JSC::JSGlobalObject> m_globalObject;97 JSC::JSGlobalObject* m_globalObject { nullptr }; 99 98 unsigned m_line { 0 }; 100 99 unsigned m_column { 0 };
Note: See TracChangeset
for help on using the changeset viewer.