Changeset 251513 in webkit


Ignore:
Timestamp:
Oct 23, 2019 5:04:57 PM (4 years ago)
Author:
Truitt Savell
Message:

Unreviewed, rolling out r251482.

r251261 broke multiple tests, reverting this as part of that
rollout.

Reverted changeset:

"[ Mac WK1 ] REGRESSION (r251261): Layout Test
inspector/console/webcore-logging.html is consistently
Failing"
https://bugs.webkit.org/show_bug.cgi?id=203173
https://trac.webkit.org/changeset/251482

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r251509 r251513  
     12019-10-23  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r251482.
     4
     5        r251261 broke multiple tests, reverting this as part of that
     6        rollout.
     7
     8        Reverted changeset:
     9
     10        "[ Mac WK1 ] REGRESSION (r251261): Layout Test
     11        inspector/console/webcore-logging.html is consistently
     12        Failing"
     13        https://bugs.webkit.org/show_bug.cgi?id=203173
     14        https://trac.webkit.org/changeset/251482
     15
    1162019-10-23  Chris Dumez  <cdumez@apple.com>
    217
  • trunk/LayoutTests/inspector/console/webcore-logging.html

    r251482 r251513  
    1818{
    1919    video.currentTime = 0;
    20     video.play().catch((err) => { });
     20    video.play();
    2121    TestPage.dispatchEventToFrontend('PlayEvent', {count: 1});
    2222}
  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r251482 r251513  
    802802http/tests/is-logged-in/ [ Skip ]
    803803
     804webkit.org/b/203173 inspector/console/webcore-logging.html [ Pass Failure ]
     805
    804806webkit.org/b/203176 [ Debug ] fast/scrolling/latching/scroll-select-bottom-test.html [ Pass Failure ]
    805807
  • trunk/Source/JavaScriptCore/ChangeLog

    r251494 r251513  
     12019-10-23  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r251482.
     4
     5        r251261 broke multiple tests, reverting this as part of that
     6        rollout.
     7
     8        Reverted changeset:
     9
     10        "[ Mac WK1 ] REGRESSION (r251261): Layout Test
     11        inspector/console/webcore-logging.html is consistently
     12        Failing"
     13        https://bugs.webkit.org/show_bug.cgi?id=203173
     14        https://trac.webkit.org/changeset/251482
     15
    1162019-10-23  Yury Semikhatsky  <yurys@chromium.org>
    217
  • trunk/Source/JavaScriptCore/inspector/ConsoleMessage.cpp

    r251482 r251513  
    118118    , m_level(level)
    119119    , m_url()
    120     , m_requestId(IdentifiersFactory::requestId(requestIdentifier))
    121 {
    122     if (globalObject)
    123         m_globalObject = { globalObject->vm(), globalObject };
    124 
     120    , m_globalObject(globalObject)
     121    , m_requestId(IdentifiersFactory::requestId(requestIdentifier))
     122{
    125123    if (!messages.size())
    126124        return;
     
    343341    if (m_arguments)
    344342        m_arguments = nullptr;
    345 
    346     if (m_globalObject)
    347         m_globalObject.clear();
    348343}
    349344
     
    354349
    355350    if (m_globalObject)
    356         return m_globalObject.get();
     351        return m_globalObject;
    357352
    358353    return nullptr;
  • trunk/Source/JavaScriptCore/inspector/ConsoleMessage.h

    r251482 r251513  
    3232
    3333#include "ConsoleTypes.h"
    34 #include "Strong.h"
    3534#include <wtf/FastMalloc.h>
    3635#include <wtf/Forward.h>
     
    9695    Vector<JSONLogValue> m_jsonLogValues;
    9796    String m_url;
    98     JSC::Strong<JSC::JSGlobalObject> m_globalObject;
     97    JSC::JSGlobalObject* m_globalObject { nullptr };
    9998    unsigned m_line { 0 };
    10099    unsigned m_column { 0 };
Note: See TracChangeset for help on using the changeset viewer.