Changeset 251544 in webkit

Timestamp:

Oct 24, 2019 9:39:56 AM (5 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Reintroduce ensureGLVideoSinkContext() fix
​https://bugs.webkit.org/show_bug.cgi?id=201401

Reviewed by Philippe Normand.

That patch was almost mechanically reverted temporarily along the rest
of the WebKitMediaSrc rework. In theory that should have been OK since
it was supposed to fix a regression of that patch... But actually
the bug was already causing problems before, the WebKitMediaSrc rework
just exposed a more common case.

It has been reported that the same bug arises when adding some CSS
styles to the <video> element, and the patch fixes the issue.

And the patch actually makes sense in any case... since without it
some perfectly valid state transitions are not covered!

So I'm reintroducing it.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-24  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Reintroduce ensureGLVideoSinkContext() fix
+        https://bugs.webkit.org/show_bug.cgi?id=201401
+
+        Reviewed by Philippe Normand.
+
+        That patch was almost mechanically reverted temporarily along the rest
+        of the WebKitMediaSrc rework. In theory that should have been OK since
+        it was supposed to fix a regression of that patch... But actually
+        the bug was already causing problems before, the WebKitMediaSrc rework
+        just exposed a more common case.
+
+        It has been reported that the same bug arises when adding some CSS
+        styles to the <video> element, and the patch fixes the issue.
+
+        And the patch actually makes sense in any case... since without it
+        some perfectly valid state transitions are not covered!
+
+        So I'm reintroducing it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
+
 2019-10-24  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -414 +414 @@
 
 #if USE(GSTREAMER_GL)
-    if (currentState == GST_STATE_READY && newState == GST_STATE_PAUSED)
+    if (currentState <= GST_STATE_READY && newState >= GST_STATE_PAUSED)
         ensureGLVideoSinkContext();
 #endif