Changeset 251568 in webkit


Ignore:
Timestamp:
Oct 24, 2019 3:48:40 PM (4 years ago)
Author:
achristensen@apple.com
Message:

REGRESSION(r251409) Service worker connection should not be established without service worker entitlement
https://bugs.webkit.org/show_bug.cgi?id=203385
<rdar://problem/37790257>

Reviewed by Chris Dumez.

r251409 introduced a new call to establishSWServerConnection that should have an entitlement check.
This was caught by a unit test in CI that is not easy to reproduce in WebKit's test. See the radar.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r251566 r251568  
     12019-10-24  Alex Christensen  <achristensen@webkit.org>
     2
     3        REGRESSION(r251409) Service worker connection should not be established without service worker entitlement
     4        https://bugs.webkit.org/show_bug.cgi?id=203385
     5        <rdar://problem/37790257>
     6
     7        Reviewed by Chris Dumez.
     8
     9        r251409 introduced a new call to establishSWServerConnection that should have an entitlement check.
     10        This was caught by a unit test in CI that is not easy to reproduce in WebKit's test.  See the radar.
     11
     12        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
     13        (WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
     14
    1152019-10-24  Brent Fulgham  <bfulgham@apple.com>
    216
  • trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

    r251547 r251568  
    107107
    108108#if ENABLE(SERVICE_WORKER)
    109     establishSWServerConnection();
     109    if (networkProcess.parentProcessHasServiceWorkerEntitlement())
     110        establishSWServerConnection();
    110111#endif
    111112}
Note: See TracChangeset for help on using the changeset viewer.