Changeset 251628 in webkit


Ignore:
Timestamp:
Oct 25, 2019 11:12:14 PM (5 years ago)
Author:
yurys@chromium.org
Message:

[GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139359

Reviewed by Devin Rousso.

Renable the test on all platforms. With the current implementation of inspector client in tests
response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
call InspectoTest.log when inspected script execution is not yet resumed.

  • inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
  • inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r251626 r251628  
     12019-10-25  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        [GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=139359
     5
     6        Reviewed by Devin Rousso.
     7
     8        Renable the test on all platforms. With the current implementation of inspector client in tests
     9        response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
     10        call InspectoTest.log when inspected script execution is not yet resumed.
     11
     12        * inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
     13        * inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
     14        * platform/gtk/TestExpectations:
     15        * platform/mac/TestExpectations:
     16        * platform/win/TestExpectations:
     17
    1182019-10-25  Eric Carlson  <eric.carlson@apple.com>
    219

  • trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt

    r188142 r251628  
    1414Evaluating in DFG frame at frame[2]: 'localVal3'
    1515Response value is 12
    16 Resumed from breakpoint
    1716inside breakpointBasic
    1817result: 42
     18Resumed from breakpoint
    1919Test complete
    2020

  • trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html

    r199592 r251628  
    4141                    InspectorProtocol.sendCommand("Runtime.evaluate", {
    4242                        expression: "dfgWithoutInline3();"
    43                     }, function(responseObject) {
    44                         ProtocolTest.log("Test complete");
    45                         ProtocolTest.completeTest();
    4643                    });
    4744                });
    … …  
    9996                        return;
    10097                    }
    101                     InspectorProtocol.sendCommand("Debugger.resume", {}, function(responseObject) {
     98                    InspectorProtocol.awaitEvent({event: "Debugger.resumed"}).then(() => {
    10299                        ProtocolTest.log("Resumed from breakpoint");
     100                        ProtocolTest.log("Test complete");
     101                        ProtocolTest.completeTest();
    103102                    });
     103                    InspectorProtocol.sendCommand("Debugger.resume");
    104104                });
    105105            });

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r251621 r251628  
    16311631webkit.org/b/136581 editing/pasteboard/drag-drop-dead-frame.html [ Failure Timeout Pass ]
    16321632
    1633 webkit.org/b/139359 inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Failure Pass Timeout ]
    1634 
    16351633webkit.org/b/139489 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Failure Pass ]
    16361634

  • trunk/LayoutTests/platform/mac/TestExpectations

    r251621 r251628  
    623623webkit.org/b/123250 plugins/destroy-during-npp-new-object-with-fallback-content.html [ Pass Failure ]
    624624
    625 inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html
    626625inspector/debugger/didSampleProbe-multiple-probes.html
    627626inspector/debugger/nested-inspectors.html

  • trunk/LayoutTests/platform/win/TestExpectations

    r251591 r251628  
    24932493# [ Debug ] inspector/layers/layers-blending-compositing-reasons.html [ Skip ]
    24942494# [ Release ] inspector/layers/layers-reflected-content.html [ Pass Timeout ]
    2495 # [ Release ] inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Failure ]
    2496 # [ Debug ] inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Skip ] # Debug Assertion
    24972495# inspector/debugger/removeBreakpoint.html [ Skip ] # Crashing
    24982496# inspector/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
Note: See TracChangeset for help on using the changeset viewer.