Changeset 251661 in webkit


Ignore:
Timestamp:
Oct 28, 2019 11:43:04 AM (4 years ago)
Author:
Jonathan Bedard
Message:

results.webkit.org: Report more descriptive configurations for non-Apple ports
​https://bugs.webkit.org/show_bug.cgi?id=203490
<rdar://problem/56658244>

Reviewed by Carlos Alberto Lopez Perez.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort):
(GtkPort.configuration_for_upload): Return use GTK as the platform.

  • Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest):
(GtkPortTest.test_default_upload_configuration):

  • Scripts/webkitpy/port/win.py:

(WinCairoPort.configuration_for_upload): Use wincairo as the platform.

  • Scripts/webkitpy/port/wpe.py:

(WPEPort):
(WPEPort.configuration_for_upload): Use WPE as the platform.

  • Scripts/webkitpy/port/wpe_unittest.py:

(WPEPortTest):
(WPEPortTest.test_default_upload_configuration):

Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r251653 r251661  
     12019-10-28  Jonathan Bedard  <jbedard@apple.com>
     2
     3        results.webkit.org: Report more descriptive configurations for non-Apple ports
     4        https://bugs.webkit.org/show_bug.cgi?id=203490
     5        <rdar://problem/56658244>
     6
     7        Reviewed by Carlos Alberto Lopez Perez.
     8
     9        * Scripts/webkitpy/port/gtk.py:
     10        (GtkPort):
     11        (GtkPort.configuration_for_upload): Return use GTK as the platform.
     12        * Scripts/webkitpy/port/gtk_unittest.py:
     13        (GtkPortTest):
     14        (GtkPortTest.test_default_upload_configuration):
     15        * Scripts/webkitpy/port/win.py:
     16        (WinCairoPort.configuration_for_upload): Use wincairo as the platform.
     17        * Scripts/webkitpy/port/wpe.py:
     18        (WPEPort):
     19        (WPEPort.configuration_for_upload): Use WPE as the platform.
     20        * Scripts/webkitpy/port/wpe_unittest.py:
     21        (WPEPortTest):
     22        (WPEPortTest.test_default_upload_configuration):
     23
    1242019-10-28  Aakash Jain  <aakash_jain@apple.com>
    225

  • trunk/Tools/Scripts/webkitpy/port/gtk.py

    r239989 r251661  
    251251        command.append("--gtk")
    252252        return command
     253
     254    def configuration_for_upload(self, host=None):
     255        configuration = super(GtkPort, self).configuration_for_upload(host=host)
     256        configuration['platform'] = 'GTK'
     257        configuration['version_name'] = self._display_server.capitalize() if self._display_server else 'Xvfb'
     258        return configuration

  • trunk/Tools/Scripts/webkitpy/port/gtk_unittest.py

    r218270 r251661  
    3434from webkitpy.common.system.filesystem_mock import MockFileSystem
    3535from webkitpy.common.system.outputcapture import OutputCapture
     36from webkitpy.port.config import clear_cached_configuration
    3637from webkitpy.port.gtk import GtkPort
    3738from webkitpy.port.pulseaudio_sanitizer_mock import PulseAudioSanitizerMock
    … …  
    7778        # This function tested in linux_get_crash_log_unittest.py
    7879        pass
     80
     81    def test_default_upload_configuration(self):
     82        clear_cached_configuration()
     83        port = self.make_port()
     84        configuration = port.configuration_for_upload()
     85        self.assertEqual(configuration['architecture'], port.architecture())
     86        self.assertEqual(configuration['is_simulator'], False)
     87        self.assertEqual(configuration['platform'], 'GTK')
     88        self.assertEqual(configuration['style'], 'release')
     89        self.assertEqual(configuration['version_name'], 'Xvfb')

  • trunk/Tools/Scripts/webkitpy/port/win.py

    r250121 r251661  
    496496        return paths
    497497
     498    def configuration_for_upload(self, host=None):
     499        configuration = super(WinCairoPort, self).configuration_for_upload(host=host)
     500        configuration['platform'] = self.port_name
     501        return configuration
     502
    498503
    499504class FTWPort(WinPort):

  • trunk/Tools/Scripts/webkitpy/port/wpe.py

    r240844 r251661  
    119119    def _get_crash_log(self, name, pid, stdout, stderr, newer_than, target_host=None):
    120120        return GDBCrashLogGenerator(self._executive, name, pid, newer_than, self._filesystem, self._path_to_driver).generate_crash_log(stdout, stderr)
     121
     122    def configuration_for_upload(self, host=None):
     123        configuration = super(WPEPort, self).configuration_for_upload(host=host)
     124        configuration['platform'] = 'WPE'
     125        return configuration

  • trunk/Tools/Scripts/webkitpy/port/wpe_unittest.py

    r219300 r251661  
    3535from webkitpy.common.system.filesystem_mock import MockFileSystem
    3636from webkitpy.common.system.outputcapture import OutputCapture
     37from webkitpy.port.config import clear_cached_configuration
    3738from webkitpy.port.wpe import WPEPort
    3839from webkitpy.port.pulseaudio_sanitizer_mock import PulseAudioSanitizerMock
    … …  
    7273        # This function tested in linux_get_crash_log_unittest.py
    7374        pass
     75
     76    def test_default_upload_configuration(self):
     77        clear_cached_configuration()
     78        port = self.make_port()
     79        configuration = port.configuration_for_upload()
     80        self.assertEqual(configuration['architecture'], port.architecture())
     81        self.assertEqual(configuration['is_simulator'], False)
     82        self.assertEqual(configuration['platform'], 'WPE')
     83        self.assertEqual(configuration['style'], 'release')
Note: See TracChangeset for help on using the changeset viewer.