Changeset 251670 in webkit


Ignore:
Timestamp:
Oct 28, 2019 1:50:47 PM (4 years ago)
Author:
Jonathan Bedard
Message:

results.webkit.org: Show results which are missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=203494
<rdar://problem/56436643>

Reviewed by Aakash Jain.

  • resultsdbpy/resultsdbpy/view/static/css/timeline.css:

(.dot.warning): Add warning dot with dark-orange color.

  • resultsdbpy/resultsdbpy/view/static/js/expectations.js:

(Expectations.colorMap): Add warning.
(Expectations.failureTypes): Ditto.
(Expectations.failureTypeMap): Ditto.
(Expectations.symbolMap): Ditto.

  • resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(Legend): Add warning bubble.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r251663 r251670  
     12019-10-28  Jonathan Bedard  <jbedard@apple.com>
     2
     3        results.webkit.org: Show results which are missing expectations
     4        https://bugs.webkit.org/show_bug.cgi?id=203494
     5        <rdar://problem/56436643>
     6
     7        Reviewed by Aakash Jain.
     8
     9        * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
     10        (.dot.warning): Add warning dot with dark-orange color.
     11        * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
     12        (Expectations.colorMap): Add warning.
     13        (Expectations.failureTypes): Ditto.
     14        (Expectations.failureTypeMap): Ditto.
     15        (Expectations.symbolMap): Ditto.
     16        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
     17        (Legend): Add warning bubble.
     18
    1192019-10-28  John Wilander  <wilander@apple.com>
    220

  • trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css

    r249443 r251670  
    2424 */
    2525
     26.dot.warning {
     27    background-color: var(--orangeDark);
     28}
     29
    2630.dot.timedout {
    2731    background-color: var(--orangeLight);

  • trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js

    r250399 r251670  
    2828        return {
    2929            success: computedStyle.getPropertyValue('--greenLight').trim(),
     30            warning: computedStyle.getPropertyValue('--orangeDark').trim(),
    3031            failed: computedStyle.getPropertyValue('--redLight').trim(),
    3132            timedout: computedStyle.getPropertyValue('--orangeLight').trim(),
    … …  
    8889    PASS: 0x40,
    8990};
    90 Expectations.failureTypes = ['failed', 'timedout', 'crashed'];
     91Expectations.failureTypes = ['warning', 'failed', 'timedout', 'crashed'];
    9192Expectations.failureTypeMap = {
     93    warning: 'WARNING',
    9294    failed: 'ERROR',
    9395    timedout: 'TIMEOUT',
    … …  
    101103Expectations.symbolMap = {
    102104    success: '✓',
     105    warning: '?',
    103106    failed: '𝖷',
    104107    timedout: timeoutImage,

  • trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

    r251401 r251670  
    830830            unexpected: plural ? 'All tests passed' : 'Test passed',
    831831        },
     832        warning: {
     833            expected: plural ? 'Some tests unexpectedly reported warnings' : 'Unexpected warning',
     834            unexpected: plural ? 'Some tests reported warnings' : 'Test warning',
     835        },
    832836        failed: {
    833837            expected: plural ? 'Some tests unexpectedly failed' : 'Unexpectedly failed',
Note: See TracChangeset for help on using the changeset viewer.