Changeset 251680 in webkit

Timestamp:

Oct 28, 2019 4:09:39 PM (4 years ago)

Author:

Alan Bujtas

Message:

Hidden framesets should provide default edgeInfo value
​https://bugs.webkit.org/show_bug.cgi?id=203506
<rdar://problem/56233726>

Reviewed by Simon Fraser.

Source/WebCore:

The grid information (and certain associated structures e.g. edegeInfo) for a frameset is updated through the layout() call.
When the used height/width computes to zero on a frameset child (frame or nested frameset), we don't run layout on the renderer thus
hidden nested framesets can only provide the default edge info.
This patch changes this behaviour and we now call layout on those hidden renderers the same way we do it on iOS.

Test: fast/frames/hidden-frameset.html

• rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::edgeInfo const):

LayoutTests:

• fast/frames/hidden-frameset-expected.txt: Added.
• fast/frames/hidden-frameset.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/frames/hidden-frameset-expected.txt (added)
• LayoutTests/fast/frames/hidden-frameset.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFrameSet.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-28  Zalan Bujtas  <zalan@apple.com>
+
+        Hidden framesets should provide default edgeInfo value
+        https://bugs.webkit.org/show_bug.cgi?id=203506
+        <rdar://problem/56233726>
+
+        Reviewed by Simon Fraser.
+
+        * fast/frames/hidden-frameset-expected.txt: Added.
+        * fast/frames/hidden-frameset.html: Added.
+
 2019-10-28  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-28  Zalan Bujtas  <zalan@apple.com>
+
+        Hidden framesets should provide default edgeInfo value
+        https://bugs.webkit.org/show_bug.cgi?id=203506
+        <rdar://problem/56233726>
+
+        Reviewed by Simon Fraser.
+
+        The grid information (and certain associated structures e.g. edegeInfo) for a frameset is updated through the layout() call.
+        When the used height/width computes to zero on a frameset child (frame or nested frameset), we don't run layout on the renderer thus
+        hidden nested framesets can only provide the default edge info.
+        This patch changes this behaviour and we now call layout on those hidden renderers the same way we do it on iOS.
+
+        Test: fast/frames/hidden-frameset.html
+
+        * rendering/RenderFrameSet.cpp:
+        (WebCore::RenderFrameSet::edgeInfo const):
+
 2019-10-28  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderFrameSet.cpp

@@ -526 +526 @@
 
             // has to be resized and itself resize its contents
-            if (width != child->width() || height != child->height()) {
-                child->setWidth(width);
-                child->setHeight(height);
+            child->setWidth(width);
+            child->setHeight(height);
 #if PLATFORM(IOS_FAMILY)
-                // FIXME: Is this iOS-specific?
-                child->setNeedsLayout(MarkOnlyThis);
+            // FIXME: Is this iOS-specific?
+            child->setNeedsLayout(MarkOnlyThis);
 #else
-                child->setNeedsLayout();
+            child->setNeedsLayout();
 #endif
-                child->layout();
-            }
+            child->layout();
 
             xPos += width + borderThickness;