Changeset 251697 in webkit


Ignore:
Timestamp:
Oct 29, 2019 7:22:47 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

[Picture-in-Picture Web API] Synchronize the attributes and properties of HTMLVideoElementPictureInPicture
​https://bugs.webkit.org/show_bug.cgi?id=203518

Patch by Peng Liu <Peng Liu> on 2019-10-29
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/picture-in-picture-api-element-attributes.html

  • Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl:
  • html/HTMLAttributeNames.in:

LayoutTests:

  • TestExpectations:
  • media/picture-in-picture-api-element-attributes-expected.txt: Added.
  • media/picture-in-picture-api-element-attributes.html: Added.
  • platform/mac-wk2/TestExpectations:
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r251696 r251697  
     12019-10-29  Peng Liu  <peng.liu6@apple.com>
     2
     3        [Picture-in-Picture Web API] Synchronize the attributes and properties of HTMLVideoElementPictureInPicture
     4        https://bugs.webkit.org/show_bug.cgi?id=203518
     5
     6        Reviewed by Eric Carlson.
     7
     8        * TestExpectations:
     9        * media/picture-in-picture-api-element-attributes-expected.txt: Added.
     10        * media/picture-in-picture-api-element-attributes.html: Added.
     11        * platform/mac-wk2/TestExpectations:
     12
    1132019-10-29  Dirk Schulze  <krit@webkit.org>
    214

  • trunk/LayoutTests/TestExpectations

    r251689 r251697  
    193193
    194194webkit.org/b/202617 imported/w3c/web-platform-tests/picture-in-picture [ Skip ]
     195
     196# PiP API tests are only relevant on mac and iPad
     197media/picture-in-picture-api-element-attributes.html [ Skip ]
    195198
    196199# Shared Workers are unsupported

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r251686 r251697  
    542542webkit.org/b/173199 [ Sierra+ ] media/navigate-with-pip-should-not-crash.html [ Pass Failure ]
    543543[ Sierra+ ] media/pip-video-going-into-fullscreen.html [ Pass ]
     544[ Sierra+ ] media/picture-in-picture-api-element-attributes.html [ Pass ]
    544545
    545546# RTL Scrollbars are enabled on Sierra WebKit2.

  • trunk/Source/WebCore/ChangeLog

    r251696 r251697  
     12019-10-29  Peng Liu  <peng.liu6@apple.com>
     2
     3        [Picture-in-Picture Web API] Synchronize the attributes and properties of HTMLVideoElementPictureInPicture
     4        https://bugs.webkit.org/show_bug.cgi?id=203518
     5
     6        Reviewed by Eric Carlson.
     7
     8        Test: media/picture-in-picture-api-element-attributes.html
     9
     10        * Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl:
     11        * html/HTMLAttributeNames.in:
     12
    1132019-10-29  Dirk Schulze  <krit@webkit.org>
    214

  • trunk/Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl

    r251160 r251697  
    3434  attribute EventHandler onleavepictureinpicture;
    3535
    36   [CEReactions] attribute boolean autoPictureInPicture;
    37   [CEReactions] attribute boolean disablePictureInPicture;
     36  [CEReactions, Reflect] attribute boolean autoPictureInPicture;
     37  [CEReactions, Reflect] attribute boolean disablePictureInPicture;
    3838};

  • trunk/Source/WebCore/html/HTMLAttributeNames.in

    r251686 r251697  
    7171autocomplete
    7272autofocus
     73autopictureinpicture
    7374autoplay
    7475autosave
    … …  
    116117dirname
    117118disabled
     119disablepictureinpicture
    118120disposition
    119121download
Note: See TracChangeset for help on using the changeset viewer.