Changeset 251727 in webkit

Timestamp:

Oct 29, 2019 1:01:12 PM (4 years ago)

Author:

dino@apple.com

Message:

[ANGLE] Window Server blocking stops single GPU systems from creating a CGLPixelFormat
​https://bugs.webkit.org/show_bug.cgi?id=203522
<rdar://problem/56685302>

Reviewed by Alex Christensen.

The Web Content Process blocks access to the Window Server. For that reason, we
must create all CGLPixelFormats with the "offline renderer" flag, even if we're
not on a dual-GPU system.

• src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: Always enable kCGLPFAAllowOfflineRenderers.

(rx::DisplayCGL::initialize):

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• src/libANGLE/renderer/gl/cgl/DisplayCGL.mm (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2019-10-29  Dean Jackson  <dino@apple.com>
+
+        [ANGLE] Window Server blocking stops single GPU systems from creating a CGLPixelFormat
+        https://bugs.webkit.org/show_bug.cgi?id=203522
+        <rdar://problem/56685302>
+
+        Reviewed by Alex Christensen.
+
+        The Web Content Process blocks access to the Window Server. For that reason, we
+        must create all CGLPixelFormats with the "offline renderer" flag, even if we're
+        not on a dual-GPU system.
+
+        * src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: Always enable kCGLPFAAllowOfflineRenderers.
+        (rx::DisplayCGL::initialize):
+
 2019-10-23  Dean Jackson  <dino@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm

@@ -84 +84 @@
         attribs.push_back(kCGLPFAOpenGLProfile);
         attribs.push_back(static_cast<CGLPixelFormatAttribute>(kCGLOGLPVersion_3_2_Core));
-        if (mSupportsGPUSwitching)
-        {
-            attribs.push_back(kCGLPFAAllowOfflineRenderers);
-        }
+        attribs.push_back(kCGLPFAAllowOfflineRenderers);
         attribs.push_back(static_cast<CGLPixelFormatAttribute>(0));
         GLint nVirtualScreens = 0;